-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup deploy-preview on Netlify to test PRs #79
Comments
There is another problem related with "not checking-in This sucks because we'll have to remember and rebuild the resources every time we change the something in the SCSS files. It is easy to forget and pull a broken version. But, in the other hand, the final users won't need to use the extended version anymore (unless they want to override something). |
Yep. There is no way. I just added the I'll update the README with the steps to make a release as soon as possible. |
Whoa. That sucks! I kinda understand position of Netlify to not have extended in their But at least on the bright side, we can proceed with deploy-preview. |
I'm trying to deploy my personal site via Netlify but due to the above I am getting the following error:
As a workaround, I thought I could build locally and then drag-and-drop the site folder onto Netlify (They also allow this for deploys). Looking into the [dearvolt@vostro dearvolt.com]$ cd themes/coder/
[dearvolt@vostro coder]$ ls
archetypes assets exampleSite images layouts LICENSE.md Makefile README.md resources static theme.toml
[dearvolt@vostro coder]$ make clean release I then open the Any ideas on how I can get my site production ready, bearing the above in mind? The site can be found in this repo. Thank you for the awesome theme and I hope I can contribute! |
@DewaldDeJager, your site at netlify is using a old version of Hugo.
Running locally, did you try running |
I just downloaded your site and ran |
@luizdepra I have already tried updating the Hugo version to I get the same behaviour when running EDIT: I don't think my change took effect. I just changed the Hugo version on Netlify again and now it works. I still don't know why running |
This is normal browser behavior, right? Did you try to use a simple webserver to test it? |
before I apologize for my English. why when I run the hugo command, that my posts doesn't appear in the public folder? |
its awesome themes. |
@AndiSusanto15 Have you tried running |
@luizdepra You're right, I think it is the absolute URL breaking when you open the |
@DewaldDeJager to generate draft mode must add -D flags, hahahaha. i'm noob. |
@luizdepra since we already have |
Sure. But I don't think this is simple. |
Ok, I figured it out. |
Here's a PR for you: #90 , but the way you setup this integration can be better, I'll send another PR for that. |
and IMO this is the better way of deploying PRs to Netlify: #91 |
Although this is a theme and not an actual website, but essentially every change we push (thorough pull requests) should be tested against
exampleSite
and we can easily setup adeploy-preview
pipeline on Netlify to generate the example site for that particular PR at hand to be able to immediately see the change in action without the need to pull down the PR locally to test..But first we need to solve for or come up with a workaround (hopefully not checking-in
resources
folder) for the fact that Netlify cannot handle Hugo extended in their CI.The text was updated successfully, but these errors were encountered: