Add default GitHub API client #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganboonhong
commented
Jan 29, 2021
dhui
requested changes
Jan 30, 2021
ganboonhong
force-pushed
the
github-default-client
branch
from
e63d1a1
to
519cd2b
Compare
dhui
requested changes
Jan 31, 2021
source/github/github.go
Outdated
| return nil, ErrNoUserInfo | ||
| } | ||
| // use http.DefaultClient | ||
| client = nil |
There was a problem hiding this comment.
Doesn't client default to nil? Invert the condition and don't bother with an else branch.
| g := &Github{} | ||
| owner := "golang-migrate" | ||
| repo := "migrate" | ||
| path := "source/github/examples/migrations" |
ganboonhong
force-pushed
the
github-default-client
branch
from
cd9553a
to
6ca622c
Compare
dhui
requested changes
Jan 31, 2021
source/github/github.go
Outdated
| return nil, ErrNoUserInfo | ||
| } | ||
| // client defaults to http.DefaultClient | ||
| client = nil |
There was a problem hiding this comment.
Replace this with var client *http.Client. You don't need to set the pointer to nil since it'll default to nil.
There was a problem hiding this comment.
Nice catch. Do you think // client defaults to http.DefaultClient comment is needed above var client *http.Client?
…e into github-default-client
ganboonhong
force-pushed
the
github-default-client
branch
from
6ca622c
to
b42a8a6
Compare
dhui
approved these changes
Jan 31, 2021
|
@dhui hey 👋 is possible to release new version containing this change? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to access the migration source from GitHub without providing personal access token.
Is it possible to add such a feature since
go-githubpackage allows unauthenticated clients to call the API?