-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goreleaser configuration and automatic release workflow #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not completely sold on using GitHub Actions over CircleCI (even though CircleCI is currently having an outage as I write this).
Do you have a preference of GitHub Actions over CircleCI and why?
Are there additional tools you need to install to use buildx that's more cumbersome with CircleCI? I noticed you were using qemu.
Here's why I chose GitHub Actions:
If the maintainer decides that CircleCI is preferable for some reasons, I'll remove the workflow config file from this PR once because I'm not familiar with CircleCI. I might try another PR. |
This PR should also unblock releases: #546 |
Sorry for the delayed response! Can you modify this to use CircleCI? |
The 2K limit only applies to private repositories. |
@Juneezee See the link and attached screenshot in my original comment. It shows 2k action minutes for "Github Free for organizations" |
I can't stress this enough. It has been clearly stated here (https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#about-billing-for-github-actions) that GitHub Actions is free for public repositories. Those minutes limit you are seeing only applies for private repositories. If you still don't believe me, you can go to the Billing & Plans section of golang-migrate organization. Under the Usage This Month, the 2K limit is clearly labelled for private repositories only. |
Ahh, thanks for the pointer @Juneezee! I can see that the minutes are only tracked for private repos: |
Hi, any progress on this? Are we able to enable the release process of this repository one more time? |
Would love to see this (or something like it) merged soon, I was using the
which (after some time) I found was fixed in #501 which is why the docs say it works so I was very confused. The lack of a CI process currently is hurting the usability of the CLI/image. I'm fine with pushing a temporary image of the latest commit from master to our internal registry but would really like to not have to maintain that in the long-run. |
FWIW we just chose GitHub Actions and GHCR for the CI and container registry of our open-source project https://github.com/hyperledger-labs/firefly due to the free build minutes for public repos, growing ecosystem of actions and features, CI being directly integrated into SCM is a great dev experience, and the lack of (relative to DockerHub) image pull rate-limiting. Perhaps as a follow up to this PR being merged, the image can be migrated from DockerHub to GHCR. |
See #604, thanks @Fontinalis |
close #74
Required settings
GitHub Actions secrets
How to release
I imagined as much as possible what the existing release workflow would look like, and followed the steps below.
If you don't like it, please send comments.
We can also automatically generate a change log for the release notes.