This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Disable parallel importer tests #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
use-h-parallel
branch
from
07b57ec
to
f59c831
Compare
carolynvs
force-pushed
the
use-h-parallel
branch
2 times, most recently
from
cbd0f9a
to
41fd7e8
Compare
Use the test helper so that it can check for any problems up-front.
Disable until we can figure out why this is causing the following error on the AppVeyor(Windows) builds: "remote repository at https://github.com/carolynvs/deptest-importers does not exist, or is inaccessible"
carolynvs
force-pushed
the
use-h-parallel
branch
from
41fd7e8
to
af9e77c
Compare
carolynvs
changed the title
jmank88
approved these changes
Sep 10, 2017
|
Everything passed except the homebrew build (still queued) because Travis has an outage. Hopefully they'll get that fixed on Monday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
The AppVeyor(Windows) build is failing with the following error and I can't figure out why.
I originally tried to fix this by making sure that each test had it's own separate GOPATH, and that they are all using
h.Parallel(). I've left that in, even though it didn't fix the tests on Windows.What should your reviewer look out for in this PR?
Nope, just need to get the build working again. Since AppVeyor isn't kicking off right now for this repo, here's a link of the build passing on my branch:
https://ci.appveyor.com/project/carolynvs/dep/build/4
Do you need help or clarification on anything?
Let's just get the build working again. If someone knows how to fix this, please jump in and submit a PR, making sure that the AppVeyor build passes (it isn't currently reporting back to GitHub).