Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Disable parallel importer tests #1143

Merged
merged 2 commits into from
Sep 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmd/dep/base_importer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ func TestBaseImporter_LookupVersionForLockedProject(t *testing.T) {
t.Run(name, func(t *testing.T) {
h := test.NewHelper(t)
defer h.Cleanup()
h.Parallel()
// Disable parallel tests until we can resolve this error on the Windows builds:
// "remote repository at https://github.com/carolynvs/deptest-importers does not exist, or is inaccessible"
//h.Parallel()

ctx := newTestContext(h)
sm, err := ctx.SourceManager()
Expand Down Expand Up @@ -396,8 +398,6 @@ func TestBaseImporter_ImportProjects(t *testing.T) {
name := name
tc := tc
t.Run(name, func(t *testing.T) {
t.Parallel()

err := tc.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
i := newBaseImporter(logger, true, sm)
convertErr := i.importPackages(tc.projects, tc.defaultConstraintFromLock)
Expand Down Expand Up @@ -426,6 +426,9 @@ type convertTestCase struct {
func (tc convertTestCase) Exec(t *testing.T, convert func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error)) error {
h := test.NewHelper(t)
defer h.Cleanup()
// Disable parallel tests until we can resolve this error on the Windows builds:
// "remote repository at https://github.com/carolynvs/deptest-importers does not exist, or is inaccessible"
//h.Parallel()

ctx := newTestContext(h)
sm, err := ctx.SourceManager()
Expand Down
2 changes: 0 additions & 2 deletions cmd/dep/glide_importer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ func TestGlideConfig_Convert(t *testing.T) {
name := name
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
g := newGlideImporter(logger, true, sm)
g.glideConfig = testCase.yaml
Expand Down
2 changes: 0 additions & 2 deletions cmd/dep/godep_importer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ func TestGodepConfig_Convert(t *testing.T) {
name := name
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
g := newGodepImporter(logger, true, sm)
g.json = testCase.json
Expand Down
10 changes: 6 additions & 4 deletions cmd/dep/gopath_scanner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ const testProject1 string = "github.com/sdboyer/deptest"
const testProject2 string = "github.com/sdboyer/deptestdos"

func TestGopathScanner_OverlayManifestConstraints(t *testing.T) {
t.Parallel()

h := test.NewHelper(t)
h.Parallel()
defer h.Cleanup()

ctx := newTestContext(h)

pi1 := gps.ProjectIdentifier{ProjectRoot: gps.ProjectRoot(testProject1)}
Expand Down Expand Up @@ -69,9 +70,10 @@ func TestGopathScanner_OverlayManifestConstraints(t *testing.T) {
}

func TestGopathScanner_OverlayLockProjects(t *testing.T) {
t.Parallel()

h := test.NewHelper(t)
h.Parallel()
defer h.Cleanup()

ctx := newTestContext(h)

rootM := dep.NewManifest()
Expand Down
2 changes: 0 additions & 2 deletions cmd/dep/govend_importer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ func TestGovendConfig_Convert(t *testing.T) {
name := name
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
g := newGovendImporter(logger, true, sm)
g.yaml = testCase.yaml
Expand Down
2 changes: 0 additions & 2 deletions cmd/dep/vndr_importer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ func TestVndrConfig_Convert(t *testing.T) {
name := name
testCase := testCase
t.Run(name, func(t *testing.T) {
t.Parallel()

err := testCase.Exec(t, func(logger *log.Logger, sm gps.SourceManager) (*dep.Manifest, *dep.Lock, error) {
g := newVndrImporter(logger, true, sm)
g.packages = testCase.packages
Expand Down