gps: pass correct arguments to "git clean" #2176
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
kevinburke
force-pushed
the
geaaru-master
branch
from
e60d294
to
f0d93a6
Compare
|
|
kevinburke
force-pushed
the
geaaru-master
branch
from
f0d93a6
to
ab63ffe
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
kevinburke
force-pushed
the
geaaru-master
branch
from
ab63ffe
to
ab4a0ad
Compare
Previously, the "-x" in
git submodule foreach --recursive git clean -x
was being applied to the "git submodule" command not the "git clean"
command. git submodule foreach expects the inner command to be wrapped
in a single string, so pass git clean as a single string.
Verified this works as expected on the command line.
Originally submitted as #2164 by Daniele Rodina
<[email protected]>, re-submitted by me to amend the commit and
merge immediately.
Fixes #2164.
Fixes #2168.
kevinburke
force-pushed
the
geaaru-master
branch
from
ab4a0ad
to
753b47d
Compare
The command passed after a "git submodule foreach" should be invoked as a single string, as it is on line 416 of this file. Otherwise "-x" is treated as an argument to "foreach" and it errors. See golang/dep#2176 for more details.
- Includes fix for submodules issue: golang/dep#2176 [#167251593](https://www.pivotaltracker.com/story/show/167251593)
Previously, the "-x" in
was being applied to the "git submodule" command not the "git clean"
command. git submodule foreach expects the inner command to be wrapped
in a single string, so pass git clean as a single string.
Verified this works as expected on the command line.
Fixes #2164.
Fixes #2168.