-
Notifications
You must be signed in to change notification settings - Fork 1k
Consolidate ProjectIndentifier sorts; drop build support for go1.7 #714
Conversation
Related: #757 |
we still feel this is relevant, right? i think, once Go 1.9 is out, i'm fine with abandoning 1.7, so we can actually use |
I'll have to rebase but it should still be partially relevant |
we'll hold off on merging this and dropping the 1.7 support until there's a full release of 1.9. in the meantime, this'll need to drop the 1.7 builder in travis - let's replace that one with 1.9. also, update the README. |
Ok to yank things tagged to build for <=1.7 too? |
ahh yes, definitely.
…On 08/18 19:42, Jordan Krage wrote:
Ok to yank things tagged to build for <=1.7 too?
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#714 (comment)
|
@@ -27,7 +27,7 @@ jobs: | |||
- codeclimate-test-reporter < coverage.txt | |||
# YAML alias, for settings shared across the simpler builds | |||
- &simple-test | |||
go: 1.7.x | |||
go: 1.9.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it needs to be just 1.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was holding out for them to update and it looks like they did at some point today. Travis is now recognizing 1.9.x and passing only 1.9 to gimme. Strange that they don't have a general rule for picking up 1.Y.X
for any Y
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weee!
#672
This change proposes consolidating
ProjectIdentifier
based sorting code in order to reduce exported API surface, and DRY up internal code.There were three slightly different methods of ordering
ProjectIdentifier
:ProjectRoot
onlyProjectRoot
, thenSource
ProjectRoot
, thennormalizedSource()
Now the sole
Less
method behind every sort is the third version.There is a dependency on sort methods introduced in go 1.8, so CI is expected to partially fail for now.