-
Notifications
You must be signed in to change notification settings - Fork 1k
increment CI go versions from 1.8.x/1.9.x/tip to 1.9.x/1.10.x/tip #1620
Conversation
Travis: |
@@ -9,7 +9,7 @@ clone_folder: c:\gopath\src\github.com\golang\dep | |||
environment: | |||
GOPATH: c:\gopath | |||
DEPTESTBYPASS501: 1 | |||
GOVERSION: 1.8 | |||
GOVERSION: 1.9 | |||
|
|||
init: | |||
- git config --global core.autocrlf input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the end of this script can now change from:
('go list github.com/golang/dep/... ^| find /i /v "/vendor/"')
to:
('go list github.com/golang/dep/...')
Alternatively, we can do |
Blocked on travis-ci/gimme#130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we switch to |
What's the difference between |
No difference. Just avoids an extra future PR for a theoretical 1.10.1. Last cycle they fixed 1.9.x quick, so I was holding out, but I'll just change it now. |
What does this do / why do we need it?
This PR increments the go versions for Travis and AppVeyor. 1.10 is only on release candidate 1, but is expected this month. I don't know if Travis/Gimme will route
1.10.x
to1.10rc1
, but in case it does and this turns green: Don't merge until 1.10 is officially released!.