This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Try to fix stale lock file problems mentioned in bug #820. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh, I don't know how to add stuff into vendor/ in the project. git submodules? uh .. This is embarrassing. @sdboyer :-( |
ibrasho
reviewed
Jul 19, 2017
| return nil, CouldNotCreateLockError{ | ||
| Path: glpath, | ||
| Err: fmt.Errorf("cache lock file %s exists - another process crashed or is still running?", glpath), | ||
| Err: fmt.Errorf("Unable to create lock %s: %s", glpath, err.Error()), |
There was a problem hiding this comment.
Start the error with a small case letter.
|
I've created a new PR to add the required vendor package and to fix the nits. |
ibrasho
reviewed
Jul 21, 2017
| _, err = os.Stat(glpath) | ||
| if err == nil { | ||
| lockfile, err := lockfile.New(glpath) | ||
| if err != nil { | ||
| return nil, CouldNotCreateLockError{ |
There was a problem hiding this comment.
Slightly related to this PR: why do we define CouldNotCreateLockError as a struct, with Path when it's always included in Err?
I recommend we update CouldNotCreateLockError.Error() to allow:
return nil, CouldNotCreateLockError{
Path: glpath,
Err: err,
}by doing the following:
func (e CouldNotCreateLockError) Error() string {
fmt.Errorf("unable to create lock %s: %s", glpath, err)
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This addresses the case where there is a stale lock file, or if there is multiple dep instances running. Each subsequent dep instance will now wait until the previous dep instances finish. The lock file will be removed if it is stale; it keeps track of which PIDs are active, and checks to see if the pid exists if it's busy.
It also should give better error messages if there is a problem.
What should your reviewer look out for in this PR?
Anything disastrous?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
fixes #820