This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
source_manager.go handle locking better #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2017 23:55
Fix nit around capital letter in error message.
…ss. We should not allow NewSourceManager to be called twice at the same time.
|
once more, with feeling. |
sdboyer
suggested changes
Jul 20, 2017
internal/gps/source_manager.go
Outdated
| } | ||
| } | ||
|
|
||
| // there is a lockfile, but it's owned by someone else. We'll try to lock |
internal/gps/source_manager.go
Outdated
| // permanently. | ||
|
|
||
| err = lockfile.TryLock() | ||
| for err != nil { |
There was a problem hiding this comment.
Having this loop be effectively unbounded AND not providing the user any feedback seems concerning. But, I'd be OK with addressing that in a follow-up - though, please make a comment on #534, as I think that'll be the appropriate way to tell the user this is happening.
| // Fix for #820 | ||
| // | ||
| // Consult https://godoc.org/github.com/nightlyone/lockfile for the lockfile | ||
| // behaviour. It's magic. It deals with stale processes, and if there is |
|
And close... |
|
And open! |
17 tasks
sdboyer
approved these changes
Jul 21, 2017
|
ok, i think we're looking good for this. i'll open a follow-up related to refactoring the interface. |
|
oh, and, woohoo! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Adds https://github.com/nightlyone/lockfile to manage the lockfile that dep uses. Concurrent use of dep no longer fails, subsequence invocations of dep will cause the subsequence instances to wait while the first runs, and then they will continue.
Also, stale lockfiles are handled correctly.
What should your reviewer look out for in this PR?
Correctness.
Do you need help or clarification on anything?
How to use git ... ;-)
Which issue(s) does this PR fix?
fixes #820
fixes #852