Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/image/draw: TestFastPaths fails on Go 1.4 #11921

Closed
bradfitz opened this issue Jul 29, 2015 · 4 comments
Closed

x/image/draw: TestFastPaths fails on Go 1.4 #11921

bradfitz opened this issue Jul 29, 2015 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@bradfitz
Copy link
Contributor

Part of #11811 (subrepos needing to be green), the image repo's tests are broken on Go 1.4:

linux-386 at 883bc6ed0ea815293fe6309d66f967ea60630e87 building image at 5c9906b5359a44e978a11bec5bb6e055bfeb984d

ok      golang.org/x/image/bmp  0.015s
--- FAIL: TestFastPaths (0.15s)
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(0,0)-(10,10), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(3,4)-(8,6), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(-3,-5)-(2,4), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(4,-2)-(6,12), src=*image.YCbCr, sr=(2,2)-(10,8), transform=false, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(12,14)-(23,45), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(12,14)-(23,45), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(12,14)-(23,45), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(12,14)-(23,45), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(12,14)-(23,45), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(12,14)-(23,45), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(5,5)-(5,5), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(5,5)-(5,5), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.nnInterpolator
    scale_test.go:552: pix differ for dr=(5,5)-(5,5), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(5,5)-(5,5), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=draw.ablInterpolator
    scale_test.go:552: pix differ for dr=(5,5)-(5,5), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
    scale_test.go:552: pix differ for dr=(5,5)-(5,5), src=*image.YCbCr, sr=(0,0)-(12,9), transform=true, q=*draw.Kernel
FAIL
FAIL    golang.org/x/image/draw 0.639s
?       golang.org/x/image/math/f32 [no test files]
?       golang.org/x/image/math/f64 [no test files]
ok      golang.org/x/image/riff 0.002s
ok      golang.org/x/image/tiff 0.133s
?       golang.org/x/image/tiff/lzw [no test files]
?       golang.org/x/image/vp8  [no test files]
?       golang.org/x/image/vp8l [no test files]
ok      golang.org/x/image/webp 0.249s
?       golang.org/x/image/webp/nycbcra [no test files]

For @nigeltao.
@bradfitz bradfitz added this to the Go1.5 milestone Jul 29, 2015
@bradfitz bradfitz changed the title x/image: TestFastPaths x/image/draw: TestFastPaths fails on Go 1.4 Jul 29, 2015
@nigeltao
Copy link
Contributor

I don't know what to do here. The x/image/draw tests have hard-coded pixel-perfect golden results. Those golden results changed between Go 1.4 and Go 1.5, as per a deliberate change to the stdlib's image/color package, e.g. https://go-review.googlesource.com/#/c/8073/

@nigeltao
Copy link
Contributor

Sorry, this particular test isn't really a compare-to-golden, it's calculate the result two ways: a fast way inside x/image/draw, and a slow way using stdlib's image/draw. The fast way is hard-coded to use Go 1.5's color conversion formulae.

@adg
Copy link
Contributor

adg commented Jul 30, 2015

Just call it "known bad" and skip it on Go 1.4.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/12861 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 5, 2016
mrhyperbit23z0d added a commit to mrhyperbit23z0d/bhegde8 that referenced this issue Jun 6, 2022
@mrhyperbit23z0d
draw: skip TestFastPaths for Go 1.4.
ae22041 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
GalaxyForcew added a commit to GalaxyForcew/A1bisshy that referenced this issue Jun 6, 2022
@GalaxyForcew
draw: skip TestFastPaths for Go 1.4.
5c926b5 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
yi-ge3 added a commit to yi-ge3/wislie that referenced this issue Jun 6, 2022
@yi-ge3
draw: skip TestFastPaths for Go 1.4.
a5fd195 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
balloontmz6 added a commit to balloontmz6/Likewise42l that referenced this issue Jun 6, 2022
@balloontmz6
draw: skip TestFastPaths for Go 1.4.
1aafb64 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
snapbakkhfbav added a commit to snapbakkhfbav/SayedBaladohr that referenced this issue Oct 6, 2022
@snapbakkhfbav
draw: skip TestFastPaths for Go 1.4.
09a6ac0 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
MiderWong5ddop added a commit to MiderWong5ddop/sidie88f that referenced this issue Oct 7, 2022
@MiderWong5ddop
draw: skip TestFastPaths for Go 1.4.
1aff4d9 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
rorypeckwnt4v added a commit to rorypeckwnt4v/LearnByBhanuPrataph that referenced this issue Oct 7, 2022
@rorypeckwnt4v
draw: skip TestFastPaths for Go 1.4.
345d696 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
egorovcharenko9 added a commit to egorovcharenko9/RiceBIOC470z that referenced this issue Oct 7, 2022
@egorovcharenko9
draw: skip TestFastPaths for Go 1.4.
6f91326 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
RafayGhafoorf added a commit to RafayGhafoorf/dustinsand8 that referenced this issue Oct 7, 2022
@RafayGhafoorf
draw: skip TestFastPaths for Go 1.4.
b293c53 
Fixes golang/go#11921

Change-Id: Iafca8b21523d486ce9b2be494b8fb93216573968
Reviewed-on: https://go-review.googlesource.com/12861
Reviewed-by: Andrew Gerrand <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@bradfitz @adg @nigeltao @gopherbot