Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text: tests fail with 1.4 #11927

Closed
mwhudson opened this issue Jul 30, 2015 · 7 comments
Closed

x/text: tests fail with 1.4 #11927

mwhudson opened this issue Jul 30, 2015 · 7 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@mwhudson
Copy link
Contributor

Is this to be expected?
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 30, 2015
@ianlancetaylor
Copy link
Contributor

CC @mpvl

@bradfitz
Copy link
Contributor

For the record,

http://build.golang.org/log/655bfcfbf1455f758a63003f3fef4d85bd6d98bc

--- FAIL: TestCaseProperties (0.21s)
    context_test.go:73: caseIgnorable(U+08E3): got true; want false (34)
    context_test.go:76: cased(U+13A0): got true; want false (4653)
    context_test.go:79: upper(U+13A0): got true; want false (4653)
    context_test.go:76: cased(U+13A1): got true; want false (4653)
    context_test.go:79: upper(U+13A1): got true; want false (4653)
    context_test.go:76: cased(U+13A2): got true; want false (4653)
    context_test.go:79: upper(U+13A2): got true; want false (4653)
....
    context_test.go:130: title:'\U00010cf1' (U+10CF1): got "\U00010cb1" [U+10CB1]; want "\U00010cf1" [U+10CF1]
    context_test.go:125: upper:'\U00010cf2' (U+10CF2): got "\U00010cb2" [U+10CB2]; want "\U00010cf2" [U+10CF2]
    context_test.go:130: title:'\U00010cf2' (U+10CF2): got "\U00010cb2" [U+10CB2]; want "\U00010cf2" [U+10CF2]
FAIL
FAIL    golang.org/x/text/cases 0.864s

@bradfitz bradfitz modified the milestones: Go1.5, Unreleased Jul 30, 2015
@bradfitz
Copy link
Contributor

Part of #11811 (build subrepos need to be green).

@bradfitz
Copy link
Contributor

bradfitz commented Aug 2, 2015

Marcel?

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/13252 mentions this issue.

@mpvl
Copy link
Contributor

mpvl commented Aug 5, 2015

Sorry, just seeing this now because of Russ' cl. Email for issue is routed to wrong email account.

Will look into properly fixing the tests. It should work across versions.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/13300 mentions this issue.

mpvl added a commit to golang/text that referenced this issue Aug 10, 2015
@mpvl
cases: changed tests to be more version-aware
07890ba 
Removed Skips introduced wit 13252.

Verified with all three possible permutations of compiler/package
version difference.

For golang/go#11811.
Fixes golang/go#11927.

Change-Id: I9c607eb5b27721384559c1d96fc49e73079b365b
Reviewed-on: https://go-review.googlesource.com/13300
Reviewed-by: Russ Cox <[email protected]>
@golang golang locked and limited conversation to collaborators Aug 5, 2016
@rsc rsc unassigned mpvl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@bradfitz @mwhudson @ianlancetaylor @mpvl @gopherbot