Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: remove test dependency on gopkg.in service [1.19 backport] #57058

Closed
gopherbot opened this issue Dec 2, 2022 · 2 comments
Closed

cmd/go: remove test dependency on gopkg.in service [1.19 backport] #57058

gopherbot opened this issue Dec 2, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19.5

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #54503 to be considered for backport to the next 1.19 minor release.

@gopherbot, please backport to Go 1.18 and 1.19. This test is very flaky lately, so we should at least backport a skip for it.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 2, 2022
@gopherbot gopherbot mentioned this issue Dec 2, 2022
Open
@gopherbot gopherbot added this to the Go1.19.5 milestone Dec 2, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/454839 mentions this issue: [release-branch.go1.19] cmd/go: skip TestScript/mod_replace_gopkgin

@bcmills bcmills modified the milestones: Go1.19.5, Go1.19.4 Dec 2, 2022
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Dec 6, 2022
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Dec 7, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 7, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging c2a2fba to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Dec 9, 2022
@prattmic
[release-branch.go1.19] cmd/go: skip TestScript/mod_replace_gopkgin
c2a2fba 
(Until it can be made hermetic.)

The gopkg.in service has had a lot of flakiness lately. Go users in
general are isolated from that flakiness by the Go module mirror
(proxy.golang.org), but this test intentionally bypasses the module
mirror because the mirror itself uses cmd/go to download the module.

In the long term, we can redirect the gopkg.in URL to the local
(in-process) vcweb server added for #27494.

In the meantime, let's skip the test to reduce the impact of upstream
outages.

Fixes #57058.
Updates #54503.

Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea
Reviewed-on: https://go-review.googlesource.com/c/go/+/454503
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
(cherry picked from commit c5f5cb659adda026d01b7fa9bd39b2ad3b58c5bf)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454839
Reviewed-by: Michael Pratt <[email protected]>
@golang golang locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19.5
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @heschi