cmd/go: remove test dependency on gopkg.in service #54503
Labels
Milestone
Comments
|
In this particular case I think GitHub was down... |
|
Change https://go.dev/cl/424594 mentions this issue: |
|
I've been having trouble with (It may be that the underlying problem is on GitHub's side, but it doesn't seem to affect the GitHub-only tests. And long-term we may want to reduce our dependence on those too.) |
dmitshur
added
Testing
gopherbot
pushed a commit
that referenced
this issue
Aug 17, 2022
Updates #54503. Change-Id: Ie13d028b09260d2d316c343b3ea812bb9cce4e6d Reviewed-on: https://go-review.googlesource.com/c/go/+/424594 Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Russ Cox <[email protected]>
joedian
added
the
NeedsFix
|
Found new dashboard test flakes for: 2022-09-09 00:28 linux-386-longtest go@3c33c3b3 cmd/go.TestScript (log)2022-09-27 21:10 linux-386-longtest go@4360fd8d cmd/go.TestScript (log)2022-09-27 21:14 linux-amd64-longtest go@3b5188ed cmd/go.TestScript (log) |
|
Found new dashboard test flakes for: 2022-11-16 14:38 linux-amd64-longtest-race go@7c8c209b cmd/go.TestScript (log)2022-11-16 16:25 linux-386-longtest go@38218f39 cmd/go.TestScript (log) |
|
Found new dashboard test flakes for: 2022-11-21 15:06 linux-amd64-longtest-race go@8614c525 cmd/go.TestScript (log) |
|
Found new dashboard test flakes for: 2022-11-21 16:19 linux-amd64-longtest-race go@d7812ab3 cmd/go.TestScript (log) |
|
Change https://go.dev/cl/454503 mentions this issue: |
|
@gopherbot, please backport to Go 1.18 and 1.19. This test is very flaky lately, so we should at least backport a skip for it. |
|
Backport issue(s) opened: #57057 (for 1.18), #57058 (for 1.19). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
gopherbot
pushed a commit
that referenced
this issue
Dec 2, 2022
(Until it can be made hermetic.) The gopkg.in service has had a lot of flakiness lately. Go users in general are isolated from that flakiness by the Go module mirror (proxy.golang.org), but this test intentionally bypasses the module mirror because the mirror itself uses cmd/go to download the module. In the long term, we can redirect the gopkg.in URL to the local (in-process) vcweb server added for #27494. In the meantime, let's skip the test to reduce the impact of upstream outages. For #54503. Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea Reviewed-on: https://go-review.googlesource.com/c/go/+/454503 Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
|
Change https://go.dev/cl/454839 mentions this issue: |
|
Change https://go.dev/cl/454840 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Dec 9, 2022
(Until it can be made hermetic.) The gopkg.in service has had a lot of flakiness lately. Go users in general are isolated from that flakiness by the Go module mirror (proxy.golang.org), but this test intentionally bypasses the module mirror because the mirror itself uses cmd/go to download the module. In the long term, we can redirect the gopkg.in URL to the local (in-process) vcweb server added for #27494. In the meantime, let's skip the test to reduce the impact of upstream outages. Fixes #57058. Updates #54503. Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea Reviewed-on: https://go-review.googlesource.com/c/go/+/454503 Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> (cherry picked from commit c5f5cb659adda026d01b7fa9bd39b2ad3b58c5bf) Reviewed-on: https://go-review.googlesource.com/c/go/+/454839 Reviewed-by: Michael Pratt <[email protected]>
gopherbot
pushed a commit
that referenced
this issue
Dec 9, 2022
(Until it can be made hermetic.) The gopkg.in service has had a lot of flakiness lately. Go users in general are isolated from that flakiness by the Go module mirror (proxy.golang.org), but this test intentionally bypasses the module mirror because the mirror itself uses cmd/go to download the module. In the long term, we can redirect the gopkg.in URL to the local (in-process) vcweb server added for #27494. In the meantime, let's skip the test to reduce the impact of upstream outages. Fixes #57057. Updates #54503. Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea Reviewed-on: https://go-review.googlesource.com/c/go/+/454503 Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> (cherry picked from commit c5f5cb659adda026d01b7fa9bd39b2ad3b58c5bf) Reviewed-on: https://go-review.googlesource.com/c/go/+/454840
|
Found new dashboard test flakes for: 2022-11-08 18:44 linux-amd64-longtest go@39ac1fbd cmd/go.TestScript (log)2022-11-16 16:42 linux-386-longtest go@0266671e cmd/go.TestScript (log)2022-11-29 15:41 linux-amd64-longtest go@8c0f9ed4 cmd/go.TestScript (log) |
|
Change https://go.dev/cl/466857 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Feb 9, 2023
Updates #54503. Change-Id: Ie13d028b09260d2d316c343b3ea812bb9cce4e6d Reviewed-on: https://go-review.googlesource.com/c/go/+/424594 Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Russ Cox <[email protected]> (cherry picked from commit c7f870e) Reviewed-on: https://go-review.googlesource.com/c/go/+/466857 Reviewed-by: Heschi Kreinick <[email protected]> Run-TryBot: David Chase <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
|
Change https://go.dev/cl/466860 mentions this issue: |
|
Change https://go.dev/cl/466861 mentions this issue: |
|
Change https://go.dev/cl/466862 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Feb 10, 2023
…ules In general it seems ok to assume that an open-source module that did exist will continue to do so — after all, users of open-source modules already do that all the time. However, we should not assume that those modules do not publish new versions — that's really up to their maintainers to decide. Two existing tests did make that assumption for the module gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests. If we need to replace them at some point, we can replace them with hermetic test-only modules (#54503) or perhaps modules owned by the Go project. Fixes #58445. Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f Reviewed-on: https://go-review.googlesource.com/c/go/+/466860 Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]>
gopherbot
pushed a commit
that referenced
this issue
Feb 10, 2023
…versions of external modules In general it seems ok to assume that an open-source module that did exist will continue to do so — after all, users of open-source modules already do that all the time. However, we should not assume that those modules do not publish new versions — that's really up to their maintainers to decide. Two existing tests did make that assumption for the module gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests. If we need to replace them at some point, we can replace them with hermetic test-only modules (#54503) or perhaps modules owned by the Go project. Updates #58445. Fixes #58449. Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f Reviewed-on: https://go-review.googlesource.com/c/go/+/466862 Reviewed-by: David Chase <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
gopherbot
pushed a commit
that referenced
this issue
Feb 10, 2023
…versions of external modules In general it seems ok to assume that an open-source module that did exist will continue to do so — after all, users of open-source modules already do that all the time. However, we should not assume that those modules do not publish new versions — that's really up to their maintainers to decide. Two existing tests did make that assumption for the module gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests. If we need to replace them at some point, we can replace them with hermetic test-only modules (#54503) or perhaps modules owned by the Go project. Updates #58445. Fixes #58450. Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f Reviewed-on: https://go-review.googlesource.com/c/go/+/466861 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]>
johanbrandhorst
pushed a commit
to Pryz/go
that referenced
this issue
Feb 12, 2023
…ules In general it seems ok to assume that an open-source module that did exist will continue to do so — after all, users of open-source modules already do that all the time. However, we should not assume that those modules do not publish new versions — that's really up to their maintainers to decide. Two existing tests did make that assumption for the module gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests. If we need to replace them at some point, we can replace them with hermetic test-only modules (golang#54503) or perhaps modules owned by the Go project. Fixes golang#58445. Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f Reviewed-on: https://go-review.googlesource.com/c/go/+/466860 Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]>
romaindoumenc
pushed a commit
to TroutSoftware/go
that referenced
this issue
Feb 14, 2023
…versions of external modules In general it seems ok to assume that an open-source module that did exist will continue to do so — after all, users of open-source modules already do that all the time. However, we should not assume that those modules do not publish new versions — that's really up to their maintainers to decide. Two existing tests did make that assumption for the module gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests. If we need to replace them at some point, we can replace them with hermetic test-only modules (golang#54503) or perhaps modules owned by the Go project. Updates golang#58445. Fixes golang#58450. Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f Reviewed-on: https://go-review.googlesource.com/c/go/+/466861 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]>
|
Change https://go.dev/cl/473276 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Apr 24, 2023
Although we aren't precise about enforcing the hosts just yet, we can eventually use the declared hostnames to selectively skip tests (for example, if an external service has an outage while a Go release is being tested). Also relax the constraint to [short] in tests that require only vcs-test.golang.org, which has redirected to an in-process server since around CL 427914. Also enforce that tests that use the network actually use the [net] constraint, by setting TESTGONETWORK=panic in the test environment until the condition is evaluated. For #52545. For #54503. Updates #27494. Change-Id: I13be6b42a9beee97657eb45424882e787ac164c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/473276 Run-TryBot: Bryan Mills <[email protected]> TryBot-Bypass: Bryan Mills <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Bryan Mills <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
gopkg.inservice has occasional downtime (most recently niemeyer/gopkg#78).Some of the
cmd/gotests ofgopkg.inmodules are isolated from outages by the Go module proxy, but unfortunately others fail when the service is down.As far as I can tell, the
go-importmetadata served bygopkg.inis mostly static. (It may add some value in serving up-to-datego-sourcemetadata, butcmd/godoes not depend on that metadata.) Since we're going to have a test-local HTTPS server anyway for #27494, perhaps we can migrate thegopkg.intests to use that server with staticgo-importmetadata instead.The text was updated successfully, but these errors were encountered: