Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modfetch: TestCodeRepo/gopkg.in_natefinch_lumberjack.v2/latest failing [1.20 backport] #58450

Closed
gopherbot opened this issue Feb 9, 2023 · 2 comments
Closed

cmd/go/internal/modfetch: TestCodeRepo/gopkg.in_natefinch_lumberjack.v2/latest failing [1.20 backport] #58450

gopherbot opened this issue Feb 9, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go modules Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.20.1

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #58445 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.20 and 1.19. These tests are broken due to benign external changes.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 9, 2023
@gopherbot gopherbot mentioned this issue Feb 9, 2023
Closed
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go CherryPickApproved Used during the release process for point releases modules labels Feb 9, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 9, 2023
@gopherbot gopherbot added this to the Go1.20.1 milestone Feb 9, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/466861 mentions this issue: [release-branch.go1.20] cmd/go: remove tests that assume lack of new versions of external modules

gopherbot pushed a commit that referenced this issue Feb 10, 2023
@dr2chase
[release-branch.go1.20] cmd/go: remove tests that assume lack of new …
1fa2deb 
…versions of external modules

In general it seems ok to assume that an open-source module that did
exist will continue to do so — after all, users of open-source modules
already do that all the time. However, we should not assume that those
modules do not publish new versions — that's really up to their
maintainers to decide.

Two existing tests did make that assumption for the module
gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests.
If we need to replace them at some point, we can replace them with
hermetic test-only modules (#54503) or perhaps modules owned by the Go
project.

Updates #58445.
Fixes #58450.

Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f
Reviewed-on: https://go-review.googlesource.com/c/go/+/466861
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: David Chase <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 1fa2deb to release-branch.go1.20.

romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Feb 14, 2023
@romaindoumenc
[release-branch.go1.20] cmd/go: remove tests that assume lack of new …
c33d9cc 
…versions of external modules

In general it seems ok to assume that an open-source module that did
exist will continue to do so — after all, users of open-source modules
already do that all the time. However, we should not assume that those
modules do not publish new versions — that's really up to their
maintainers to decide.

Two existing tests did make that assumption for the module
gopkg.in/natefinch/lumberjack.v2. Let's remove those two tests.
If we need to replace them at some point, we can replace them with
hermetic test-only modules (golang#54503) or perhaps modules owned by the Go
project.

Updates golang#58445.
Fixes golang#58450.

Change-Id: Ica8fe587d86fc41f3d8445a4cd2b8820455ae45f
Reviewed-on: https://go-review.googlesource.com/c/go/+/466861
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: David Chase <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go modules Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.20.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot