Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failures with exit status 1 #64807

Closed
gopherbot opened this issue Dec 19, 2023 · 9 comments
Closed

x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failures with exit status 1 #64807

gopherbot opened this issue Dec 19, 2023 · 9 comments
Assignees
@matloob
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Dec 19, 2023 •
edited by bcmills
Loading 

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/tests/deps" && test == "TestCmdPkgsiteDeps" && `running go list:\s*exit status \d+` && date < "2024-01-04"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCmdPkgsiteDeps (6.09s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 19, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/tests/deps" && test == "TestCmdPkgsiteDeps"
2023-12-19 21:19 android-386-emu pkgsite@4356cead go@35222eeb x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (6.09s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1
2023-12-19 21:19 android-amd64-emu pkgsite@4356cead go@35222eeb x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (4.63s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Dec 19, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/tests/deps" && test == "TestCmdPkgsiteDeps"
2023-12-21 23:35 android-386-emu pkgsite@aba46575 go@2184a394 x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.65s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1
2023-12-21 23:35 android-amd64-emu pkgsite@aba46575 go@2184a394 x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.02s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/tests/deps" && test == "TestCmdPkgsiteDeps"
2023-12-24 13:03 android-386-emu pkgsite@475d4c57 go@2184a394 x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.88s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1
2023-12-24 13:03 android-amd64-emu pkgsite@475d4c57 go@2184a394 x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.26s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 2, 2024

This could be a network error of some sort, but without a more useful test failure watchflakes can't match it to an existing issue.

Probably a good first step would be to update the call to t.Fatal to log the Stderr field if the error is an *exec.ExitError.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jan 2, 2024
@bcmills
Copy link
Contributor

bcmills commented Jan 2, 2024

(attn @matloob)

@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 2, 2024
@bcmills bcmills changed the title x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failures x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failures with exit status 1 Jan 3, 2024
@bcmills bcmills added FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed help wanted labels Jan 3, 2024
@bcmills
Copy link
Contributor

bcmills commented Jan 3, 2024

https://go.dev/cl/553516 is in flight to add diagnostics for this test.

@bcmills bcmills removed the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jan 3, 2024
@bcmills bcmills mentioned this issue Jan 3, 2024
Open
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/553516 mentions this issue: internal/tests/deps: add more information to error message

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 3, 2024
@matloob
internal/tests/deps: add more information to error message
eb2fcc3 
For golang/go#64807

Change-Id: Ie2b95ccf0c77ceb8d4a138a767937e3751db7a76
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/553516
LUCI-TryBot-Result: Go LUCI <[email protected]>
Run-TryBot: Michael Matloob <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
kokoro-CI: kokoro <[email protected]>
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/tests/deps" && test == "TestCmdPkgsiteDeps" && `running go list:\s*exit status \d+`
2024-01-03 16:21 android-386-emu pkgsite@e232f565 go@7d1b82db x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.97s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1
2024-01-03 16:21 android-386-emu pkgsite@e232f565 go@aa0a6ad1 x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.90s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1
2024-01-03 16:21 android-amd64-emu pkgsite@e232f565 go@7d1b82db x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.40s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1
2024-01-03 16:21 android-amd64-emu pkgsite@e232f565 go@aa0a6ad1 x/pkgsite/internal/tests/deps.TestCmdPkgsiteDeps (log) 
--- FAIL: TestCmdPkgsiteDeps (5.16s)
    cmd_pkgsite_deps_test.go:36: running go list:  exit status 1

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 4, 2024

Fixed in https://go.dev/cl/553516.

@bcmills bcmills closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matloob matloob

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @matloob