-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/endpoint gets proxied to /endpoint/ #43
Comments
…L if they are already there, if they aren't there, we don't want to add it. This PR adds logic to handle this properly. Please see issue gonzalocasas#43 for reference
My thoughts: I don't write code for this module any more. I'm pretty sure the first version I released didn't have this problem. I just merge pull requests if the tests pass and cut releases. It's an experiment in a community maintained module. |
my PR broke the tests; working on fixing that now. I'll let you know when they're up to snuff, thanks! |
this issue can be closed, fix landed in v0.15.0 d3f462e |
jeez, feel stupid here, but when I fixed the tests I somehow reverted my fix ... 👎 let's keep this open, sending another PR - its been a long week! |
Thanks for making a fix. Instead of spending time making a PR I just switched to |
We are experiencing the same issue. This module is used in ionic and our proxies pointing to /endpoint are redirecting to /endpoint/ causing an issue. Are there any other workarounds? |
@koga73 I know it's late, but there is a workaround using the
This is possible thanks to the url rewriting made with this |
@Pyo25 i think it's not the same question
i'm facing the problem,when |
I have an endpoint
/endpoint
which I want to proxy to, however all my requests get redirected to/endpoint/
which doesn't exist.It is set up like so:
app.use('/endpoint', proxy('http://somehost.com/endpoint'));
The error seems to be somewhere in
slashJoin
inindex.js
.The text was updated successfully, but these errors were encountered: