slashJoin() enhancement #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L if they are already there, if they aren't there, we don't want to add it. This PR adds logic to handle this properly. Please see issue gonzalocasas#43 for reference
|
Let me fix this.. sorry. |
….org/api/assert.html#assert_assert_strictequal_actual_expected_message. The actual and expected parameters were reversed (if I am reading the code right)
…ren't already not working off master) - proxy test if stream ended is not working on a fresh clone
|
@andrewrk tests pass, please merge, thanks! |
….org/api/assert.html#assert_assert_strictequal_actual_expected_message. The actual and expected parameters were reversed (if I am reading the code right)
|
Thanks for merging! Could you please @ mention me when you bump the version and publish to npm? I'd like to test the new version out in hiddentao/gulp-server-livereload and see if I can get @hiddentao to bump the version there as well. |
|
@jlank 0.15.0 released and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified slashJoin() to maintain trailing slashes in the path of a URL if they are already there, if they aren't there, we don't want to add it. This PR adds logic to handle this properly. Please see issue #43 for reference