Moe Sync #675
Merged
Moe Sync #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #632 RELNOTES=`@AutoService` now has a separate artifact (`auto-service-annotations`) separate from the annotation processor (still `auto-service`) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219696198
RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=219712298
to avoid serializing such fields. Not having this causes serialization to be nondeterministic, depending on whether or not the memoized accessor has been called. This is more robust than depending on the @lazyinit annotation, which the processor sometimes can't find. RELNOTES=none ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220301585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Separate AutoService annotations and processor
Fixes #632
RELNOTES=
@AutoServicenow has a separate artifact (auto-service-annotations) separate from the annotation processor (stillauto-service)abf766b
Enable a test for a bug that's been fixed for a while
0ceb424
Adds the transient modifier to the cache field. This tells serialization to avoid serializing such fields. Not having this causes serialization to be nondeterministic, depending on whether or not the memoized accessor has been called.
This is more robust than depending on the @lazyinit annotation, which the processor sometimes can't find.
RELNOTES=none
54ca2b7