Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moe Sync #675

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Moe Sync #675

merged 3 commits into from
Nov 6, 2018

Commits on Nov 6, 2018

  1. Separate AutoService annotations and processor 

    Fixes #632

RELNOTES=`@AutoService` now has a separate artifact (`auto-service-annotations`) separate from the annotation processor (still `auto-service`)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219696198
    @ronshapiro
    ronshapiro committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    abf766b View commit details
    Browse the repository at this point in the history

  2. Enable a test for a bug that's been fixed for a while 

    RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=219712298
    @ronshapiro
    ronshapiro committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    0ceb424 View commit details
    Browse the repository at this point in the history

  3. Adds the transient modifier to the cache field. This tells serialization 

    to avoid serializing such fields. Not having this causes serialization
to be nondeterministic, depending on whether or not the memoized accessor has
been called.

This is more robust than depending on the @lazyinit annotation, which the processor sometimes can't find.

RELNOTES=none

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=220301585
    @aoeui @ronshapiro
    aoeui authored and ronshapiro committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    54ca2b7 View commit details
    Browse the repository at this point in the history