Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cushon
approved these changes
Sep 19, 2023
cushon
approved these changes
Sep 19, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…ble via flags In some cases projects have conventions about use of custom arguments/variables that are not meant to be deleted even if unused. One of such examples could be keeping an ORMs `Session session` argument in the method arguments signifying that the method happens within the boundaries of provided session and is doing calls to the underlying datastore. This PR would allow to provide custom values for exemptPrefixes and exemptNames via error-prone flags. Fixes #2753 FUTURE_COPYBARA_INTEGRATE_REVIEW=#2753 from bezmax:unused-variable-parameters 36b9502 PiperOrigin-RevId: 566671352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases projects have conventions about use of custom arguments/variables that are not meant to be deleted even if unused. One of such examples could be keeping an ORMs
Session sessionargument in the method arguments signifying that the method happens within the boundaries of provided session and is doing calls to the underlying datastore.This PR would allow to provide custom values for exemptPrefixes and exemptNames via error-prone flags.