-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade error-prone to the latest release #2651
Conversation
Generate changelog in
|
// errorprone must be temporarily disabled in order to bump the errorprone dependency | ||
// to a version without `ErrorProneFlags.getList(String)`. | ||
enabled = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that this can be safely removed after the meta-baseline-upgrade by compiling the project without this block using a publishToMavenLocal
.
I'm hopeful that something in this bump improves jdk-21 compatibility, we've seen exceptions thrown from safe-logging analysis in a couple places. |
Released 5.30.0 |
==COMMIT_MSG==
Upgrade error-prone to the latest release
==COMMIT_MSG==
This includes:
Error Prone 2.22.0
New checks:
ClosingStandardOutputStreams: Prevents accidentally closing System.{out,err} with try-with-resources
TruthContainsExactlyElementsInUsage: containsExactly is preferred over containsExactlyElementsIn when creating new iterables
UnnecessaryAsync: detects unnecessary use of async primitives in local (and hence single-threaded) scopes
ReturnAtTheEndOfVoidFunction: detects unnecessary return statements at the end of void functions
MultimapKeys: Suggests using keySet() instead of iterating over Multimap.keys(), which does not collapse duplicates
Bug fixes and improvements:
Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
Prevent SuggestedFixes#renameMethod from modifying return type declaration (google/error-prone#4043)
Fix UnusedVariable false positives for private record parameters (google/error-prone#2713)
When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (google/error-prone#2910)
CanIgnoreReturnValueSuggester: Support additional exempting method annotations (google/error-prone#4009)
UnusedVariable: exclude junit5's @RegisterExtension (google/error-prone#3892)
Support running all available patch checks (google/error-prone#947)
Upgrade java-diff-utils 4.0 -> 4.12 (google/error-prone#4081)
Flag unused Refaster template parameters (google/error-prone#4060)
Support @SuppressWarnings("all") (google/error-prone#4065)
Prevent Refaster UMemberSelect from matching method parameters (google/error-prone#2456)
MissingDefault : Don't require // fall out comments on expression switches (google/error-prone#2709)
Skip UnnecessaryLambda findings for usages in enhanced for loops (google/error-prone#2518)
Fix bug where nested MissingBraces violations' suggested fixes result in broken code (google/error-prone#3797)
Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (google/error-prone#2753)
UnusedMethod: Added exempting variable annotations (google/error-prone#2881)
Full Changelog: google/error-prone@v2.21.1...v2.22.0
Error Prone 2.23.0
New checks:
DuplicateDateFormatField
NonFinalStaticField
StringCharset
StringFormatWithLiteral
SuperEqualsIsObjectEquals
Bug fixes and improvements: google/error-prone#3897, google/error-prone#4114, google/error-prone#4123
Full Changelog: google/error-prone@v2.22.0...v2.23.0