Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for URL escaping for ref parameters #1101

Closed
gmlewis opened this issue Jan 19, 2019 · 7 comments
Closed

Add unit tests for URL escaping for ref parameters #1101

gmlewis opened this issue Jan 19, 2019 · 7 comments

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 19, 2019

This issue is so that we don't lose track of @gauntface's comment about adding unit tests to #1099.

@vaibhavsingh97
Copy link
Contributor

@gmlewis I want to take this issue. Please assign to me

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 19, 2019

I can't assign the issue to you, @vaibhavsingh97 but consider it yours.
Thank you!

@vaibhavsingh97
Copy link
Contributor

Thanks, will send PR for same 🤗

@Avni-Sharma
Copy link

Hi @vaibhavsingh97 , are you working on this?

@vaibhavsingh97
Copy link
Contributor

@Avni-Sharma yes, sorry for the delay was a busy week, will send PR shortly

@vaibhavsingh97
Copy link
Contributor

@gmlewis I am stuck here for long time, please help me with this
I wrote the unit test but I don't know how to test it. I read how to contribute file aka contributing.md, but when I forked the repository and run go build ./... and go test ./... and it failed to find packages but when I clone go-github and run same commands then I am able to build and compile
image

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 7, 2019

It looks like you are missing dependencies needed by this package. You should be able to run go get -u github.com/google/go-github and it will get all the needed dependencies. Alternatively, you can run go get -u on each package that is missing, but that shouldn't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants