do not encode / in ref names #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes google#1432 Signed-off-by: Hanno Hecker <[email protected]>
googlebot
added
the
cla: yes
gmlewis
requested changes
Feb 17, 2020
There was a problem hiding this comment.
Thank you, @vetinari!
Before we merge this, can you please add unit test(s) that demonstrate the before/after effects of this change?
Also, please add a comment to the new refURLEscape function (even though it isn't exported) with text that shows what kind of URLs this function fixes.
this is not visible in the original tests, because the muxter uses url.Path and not url.RawPath to match the route.
gmlewis
requested changes
Feb 17, 2020
| func refURLEscape(ref string) string { | ||
| parts := strings.Split(ref, "/") | ||
| for i, s := range parts { | ||
| parts[i] = url.QueryEscape(s) | ||
| parts[i] = url.PathEscape(s) |
There was a problem hiding this comment.
Hmmm... with this change from url.QueryEscape to url.PathEscape, I'm now concerned that we are breaking what was fixed in #1099.
Can you please add a unit test that demonstrates the URL found in #1099?
Unfortunately, I did not request that unit tests be added in #1099 to demonstrate the before/after changes. :-(
But I'm trying to fix that now.
as given in the original google#1099
|
Thank you, @wesleimp! |
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1432
Signed-off-by: Hanno Hecker [email protected]