We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could you consider reverting #1111 please? Those API endpoints happen to be used by both the GitHub Services feature, which is being deprecated (as mentioned in #1109), but also by repository webhooks which are still very much a supported feature from what I can tell. https://developer.github.com/v3/guides/replacing-github-services/#replacing-services-with-webhooks mentions that the migration path is to use webhooks, and https://developer.github.com/webhooks/#webhooks still mentions both organization and repository webhooks. Finally, the announcement specifically states that the particular APIs that were removed in #1111
affect the following endpoints for service hooks only
i.e. they're still vaild for repository hooks themselves.
FYI, I stumbled across this whilst trying to update the vendored version of go-github in https://github.com/terraform-providers/terraform-provider-github.
The text was updated successfully, but these errors were encountered:
I apologize, @mattburgess - this is my fault. I'll revert.
Sorry, something went wrong.
That's awesome customer service @gmlewis thanks! The terraform github provider passes a make build and make test run against v24.0.0.
make build
make test
No branches or pull requests
Could you consider reverting #1111 please? Those API endpoints happen to be used by both the GitHub Services feature, which is being deprecated (as mentioned in #1109), but also by repository webhooks which are still very much a supported feature from what I can tell. https://developer.github.com/v3/guides/replacing-github-services/#replacing-services-with-webhooks mentions that the migration path is to use webhooks, and https://developer.github.com/webhooks/#webhooks still mentions both organization and repository webhooks. Finally, the announcement specifically states that the particular APIs that were removed in #1111
i.e. they're still vaild for repository hooks themselves.
FYI, I stumbled across this whilst trying to update the vendored version of go-github in https://github.com/terraform-providers/terraform-provider-github.
The text was updated successfully, but these errors were encountered: