Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removing 3 service hooks endpoints from the code and the test" #1115

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 9, 2019

Reverts #1111.
Fixes #1114.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Feb 9, 2019
Copy link
Contributor

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I completely mis-understood the GitHub post on this, but re-reading it makes sense now.

Thanks for reverting so quickly @gmlewis

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 12, 2019

It wasn't your fault, @gauntface - I take full blame.
Thanks for the review!
Merging.

@gmlewis gmlewis merged commit 2d47288 into master Feb 12, 2019
joshuabezaleel pushed a commit to joshuabezaleel/go-github that referenced this pull request Feb 15, 2019
…he test file (google#1111)" (google#1115)

This reverts commit cf38b2b.
The version will be bumped.
@gmlewis gmlewis deleted the revert-1111-remove-service-hooks-endpoints branch June 14, 2019 12:31
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
…he test file (google#1111)" (google#1115)

This reverts commit cf38b2b.
The version will be bumped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants