-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing 3 service hooks endpoints from the code and the test #1111
Removing 3 service hooks endpoints from the code and the test #1111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joshuabezaleel!
LGTM.
Awaiting second LGTM before merging.
Note to self: must bump the release number after this breaking API change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clean up @joshuabezaleel
Thank you, @gauntface! |
This is my first PR, thank you very much @gmlewis @gauntface , for allowing to do so. It gave me great encouragement. Will definitely try to contribute more in the future! |
…he test file (google#1111)" (google#1115) This reverts commit cf38b2b. The version will be bumped.
…he test file (google#1111)" (google#1115) This reverts commit cf38b2b. The version will be bumped.
Issue: #1109
According to this post, there will be 3 endpoints affected which will be deprecated: Edit a Hook, Test a Hook, and Ping a Hook. This PR removes the code regarding those 3 endpoints and also from the test file.
cc: @gmlewis