Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Discussions webhook event #2221

Closed
maruTA-bis5 opened this issue Dec 8, 2021 · 7 comments · Fixed by #2230
Closed

Support Discussions webhook event #2221

maruTA-bis5 opened this issue Dec 8, 2021 · 7 comments · Fixed by #2230
Assignees
@maniSbindra
Labels
enhancement good first issue

Comments

@maruTA-bis5
Copy link

GitHub Discussions was out of beta in August 2021 (https://github.blog/2021-08-17-github-discussions-out-of-beta/).

Webhook event document is here: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#discussion
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2021

Thank you, @maruTA-bis5 !
Would you like to create a PR to support this feature, or shall I open this issue up to our volunteer contributors to implement?

@maniSbindra
Copy link
Contributor

Hi @gmlewis I would like to start contributing to this repository. Can I take up this issue?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 9, 2021

Hi @gmlewis I would like to start contributing to this repository. Can I take up this issue?

Thanks, @maniSbindra , but let's please wait until @maruTA-bis5 has a chance to answer my question above.

@maniSbindra
Copy link
Contributor

My bad I assumed that you and @maruTA-bis5 communicated outside this discussion, and then you moved issue to good first issue. sorry about that.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 9, 2021

My bad I assumed that you and @maruTA-bis5 communicated outside this discussion, and then you moved issue to good first issue. sorry about that.

No problem, @maniSbindra . We'll give @maruTA-bis5 another day or so, then feel free to remind me if we don't hear back, and the issue can be yours.

@maruTA-bis5
Copy link
Author

Hi @gmlewis @maniSbindra
I'm sorry to have kept you waiting!
I have no time to provide a PR for the next few weeks. So you can take up this issue, @maniSbindra.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 9, 2021

Thank you, @maruTA-bis5 and no problem.
@maniSbindra - this issue is yours.

maniSbindra added a commit to maniSbindra/go-github that referenced this issue Dec 15, 2021
@maniSbindra
Enhancement to Add Support for Discussions Webhook Event
e76081e 
This commit has changes to enable support to receive Discussions Webhook Events, to fix google#2221.
Changes include:
- Addition of event type for this type of event
- Changes for identification and mapping of DiscussionEvent
- Addition / Modification of relevent tests
maniSbindra added a commit to maniSbindra/go-github that referenced this issue Dec 15, 2021
@maniSbindra
Enhancement to Add Support for Discussions Webhook Event (google#2221)
5ebd892 
This commit has changes to enable support to receive Discussions Webhook Events, to fix google#2221.
Changes include:
- Addition of event type for this type of event
- Changes for identification and mapping of DiscussionEvent
- Addition / Modification of relevent tests
- Addition of files created by go generate
@maniSbindra maniSbindra mentioned this issue Dec 15, 2021
Merged
gmlewis pushed a commit that referenced this issue Jan 3, 2022
@maniSbindra
Add DiscussionEvent webhook (#2221) (#2230)
6e66a89 
Fixes: #2221.
@gmlewis gmlewis mentioned this issue Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maniSbindra maniSbindra

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DiscussionEvent webhook (google#2221) maniSbindra/go-github
3 participants
@maruTA-bis5 @maniSbindra @gmlewis