Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DiscussionEvent webhook (google#2221) #2230

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Add DiscussionEvent webhook (google#2221) #2230

merged 3 commits into from
Jan 3, 2022

Conversation

maniSbindra
Copy link
Contributor

This commit has changes to enable support to receive Discussions Webhook Events, to fix #2221.
Changes include:

  • Addition of event type for this type of event (DiscussionEvent)
  • Changes for identification and mapping of DiscussionEvent
  • Addition / Modification of relevant tests
  • Addition of files created by go generate

@maniSbindra
Enhancement to Add Support for Discussions Webhook Event (google#2221)
5ebd892 
This commit has changes to enable support to receive Discussions Webhook Events, to fix google#2221.
Changes include:
- Addition of event type for this type of event
- Changes for identification and mapping of DiscussionEvent
- Addition / Modification of relevent tests
- Addition of files created by go generate
gmlewis
gmlewis requested changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maniSbindra !
Just a few minor tweaks, please.

github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

Merging #2230 (106b810) into master (fef3638) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
- Coverage   97.81%   97.79%   -0.03%     
==========================================
  Files         112      113       +1     
  Lines       10117    10158      +41     
==========================================
+ Hits         9896     9934      +38     
- Misses        154      156       +2     
- Partials       67       68       +1
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)
github/github.go 97.62% <0.00%> (ø)
github/apps_hooks_deliveries.go 92.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef3638...106b810. Read the comment docs.

@maniSbindra
Copy link
Contributor Author

Thank you, @maniSbindra ! Just a few minor tweaks, please.

Thanks @gmlewis , I have incorporated the changes, request you to please review.

@gmlewis gmlewis changed the title Enhancement to Add Support for Discussions Webhook Event (google#2221) Add Discussions webhook event (google#2221) Dec 17, 2021
@gmlewis gmlewis changed the title Add Discussions webhook event (google#2221) Add DiscussionEvent webhook (google#2221) Dec 17, 2021
gmlewis
gmlewis requested changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maniSbindra !
Just one minor tweak, please, then we should be ready for a second LGTM before merging.

Note that any other contributor to this repo is welcome to provide the second approval and LGTM. Thank you!

github/messages_test.go Show resolved Hide resolved
gmlewis
gmlewis approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maniSbindra !
LGTM.

Awaiting second LGTM from any other contributor to this repo.

Parker77
Parker77 approved these changes Jan 3, 2022
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 3, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 6e66a89 into google:master Jan 3, 2022
@gmlewis gmlewis mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parker77 Parker77 Parker77 approved these changes

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Discussions webhook event
3 participants
@maniSbindra @gmlewis @Parker77