Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting actions permissions for a repository #2297

Closed
cfarrend opened this issue Feb 22, 2022 · 5 comments · Fixed by #2315
Closed

Support for setting actions permissions for a repository #2297

cfarrend opened this issue Feb 22, 2022 · 5 comments · Fixed by #2315
Assignees

Comments

@cfarrend
Copy link

cfarrend commented Feb 22, 2022

Currently in action_runners.go, there is support for getting and setting actions permissions on the organization level but not on the repository level.

Endpoints to add:
https://docs.github.com/en/rest/reference/actions#get-github-actions-permissions-for-a-repository
https://docs.github.com/en/rest/reference/actions#set-github-actions-permissions-for-a-repository

Additionally for allowed_actions: selected (not required for myself as I'm only setting enabled: false):
https://docs.github.com/en/rest/reference/actions#get-allowed-actions-for-a-repository
https://docs.github.com/en/rest/reference/actions#set-allowed-actions-for-a-repository

Happy to pick up the first part of this issue and additionally the second later on. If I am missing something, please let me know, but I'm pretty sure there isn't support based on my basic searching of the repo and issues.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 22, 2022

Thank you, @cfarrend - it looks like you are right.
Yes, that would be great! Please check out the CONTRIBUTING.md guide for tips on making PRs for this repo.
You will particularly want to know about go generate ./... and try not to use force-push since we squash as many commits as you have all into one upon merge.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 16, 2022

I apologize, @cfarrend , as we normally discuss change-of-ownership for open issues before actually switching owners, and I'm sorry if you have already invested time and effort into this issue.

However, @h2floh has submitted a PR for this open issue. Once @h2floh signs the CLA, I will switch ownership of this issue from you to @h2floh unless you object (in which case we can discuss the situation).

@cfarrend
Copy link
Author

@gmlewis No issues from my side 🙂

@h2floh
Copy link

h2floh commented Mar 17, 2022

👋 Again my apologies!

@gmlewis, I internally requested that I will be added on our company's contributor list, we have an existing CLA. Should be done within a few days.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 17, 2022

👋 Again my apologies!

@gmlewis, I internally requested that I will be added on our company's contributor list, we have an existing CLA. Should be done within a few days.

No problem, @h2floh - please remind me in a couple days if you see that this hasn't moved forward, and I'll check again.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants