-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting actions permissions on a repository #2315
Conversation
Signed-off-by: GitHub <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2315 +/- ##
==========================================
+ Coverage 97.84% 97.85% +0.01%
==========================================
Files 115 117 +2
Lines 10416 10466 +50
==========================================
+ Hits 10192 10242 +50
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
Hey @gmlewis , I signed the ICLA after my company asked me to do that. Can you please rerun the cla check. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @h2floh !
Just a few tweaks, please, then we should be ready for a second review before merging.
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
@Parker77 - do you have time for a code review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @h2floh !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you, @Parker77 ! |
👋 Hello there!
Couldn't find a PR for it yet so added functionality requested in #2297
Sorry if I pushed myself before @cfarrend in doing it but I will need the changes.
Went through the contributing guide and also added an example to test the change end2end.
Thanks everyone!
Fixes: #2297.