Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List[Organization]Runners does not support all query parameters #3093

Closed
fentas opened this issue Mar 5, 2024 · 0 comments · Fixed by #3094
Closed

List[Organization]Runners does not support all query parameters #3093

fentas opened this issue Mar 5, 2024 · 0 comments · Fixed by #3094
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Comments

@fentas
Copy link
Contributor

fentas commented Mar 5, 2024

According to the docs ListRunners and ListOrganizationRunners support name filter as query parameter.

Right now, only ListOptions is used.
I will create a PR for this.
@fentas fentas mentioned this issue Mar 5, 2024
Merged
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Mar 5, 2024
gmlewis pushed a commit that referenced this issue May 1, 2024
@fentas
feat!: Add ListRunnersOptions to support all query parameters (#3094)
faffd29 
Fixes: #3093.

BREAKING-CHANGE: This changes `ListOptions` to  `ListRunnersOptions` in `ListRunners` and `ListOrganizationRunners`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Add ListRunnersOptions to support all query parameters fentas/go-github
2 participants
@fentas @gmlewis