-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add ListRunnersOptions to support all query parameters #3094
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @fentas !
One tweak, please, then you will need to update your tests and run step 4 scripts listed in CONTRIBUTING.md.
Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
I'll also change the PR title to note that this is a breaking API change.
8c8f016
to
765fbf8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.86%
==========================================
Files 153 170 +17
Lines 13390 11403 -1987
==========================================
- Hits 13085 10590 -2495
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
Just for future reference, you never need to force push to PRs in this repo (and we prefer if you don't to make reviews easier to see what changed) because we always squash and merge here. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @fentas !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Thank you, @be0x74a ! |
Fixes: #3093.
BREAKING-CHANGE: This changes
ListOptions
toListRunnersOptions
inListRunners
andListOrganizationRunners
.Let me know if something is missing 🙌
Edit: I agreed to the CLA.