Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for JSON resource marshaling #2521

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Add test case for JSON resource marshaling #2521

merged 8 commits into from
Oct 25, 2022

Conversation

Harikesh00
Copy link
Contributor

@Harikesh00 Harikesh00 commented Oct 25, 2022 •
edited by gmlewis
Loading

Added test for User with more data

Helps: #55.

@gmlewis gmlewis changed the title Added test cases for JSON resource marshaling Add test case for JSON resource marshaling Oct 25, 2022
gmlewis
gmlewis requested changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Harikesh00 !
One tiny nit, please.

github/users_test.go Outdated Show resolved Hide resolved
@Harikesh00
Copy link
Contributor Author

@gmlewis kindly add the hacktoberfest accepted label

gmlewis
gmlewis approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Harikesh00 !
LGTM.
Merging.

@gmlewis gmlewis merged commit 2e86465 into google:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Harikesh00 @gmlewis @akshaypatil3096 @vaibhavgholap23 @sayalideshmukh10