Skip to content

Commit

Permalink
Apply buildifier to existing files (#1090)
Browse files Browse the repository at this point in the history
Before we start applying lint checks for BUILD.bazel and *.bzl files in
GitHub Actions (#1089), this commit aims to fix existing lint errors by
actually applying 'buildifier' [1] locally.

This is just a style fix in build files. There must be no observable
behavior change in artifacts.

 [1]: https://github.com/bazelbuild/buildtools/

PiperOrigin-RevId: 688131325
  • Loading branch information
yukawa authored Oct 22, 2024
1 parent 774b558 commit 20b02d2
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
31 changes: 17 additions & 14 deletions src/bazel/BUILD.qt.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
load("@build_bazel_rules_apple//apple:apple.bzl",
"apple_dynamic_framework_import")
load(
"@build_bazel_rules_apple//apple:apple.bzl",
"apple_dynamic_framework_import",
)

package(
default_visibility = ["//visibility:public"],
)
Expand All @@ -11,42 +14,42 @@ package(
cc_library(
name = "qt_mac_core",
hdrs = glob(["lib/QtCore.framework/Headers/*"]),
include_prefix = "QtCore",
includes = [
"lib/QtCore.framework/Headers",
"lib/QtCore.framework/Headers/QtCore",
"lib/QtCore.framework/Headers",
"lib/QtCore.framework/Headers/QtCore",
],
include_prefix = "QtCore",
strip_include_prefix = "lib/QtCore.framework/Headers",
)

cc_library(
name = "qt_mac_gui",
hdrs = glob(["lib/QtGui.framework/Headers/*"]),
include_prefix = "QtGui",
includes = [
"lib/QtGui.framework/Headers",
"lib/QtGui.framework/Headers/QtGui",
"lib/QtGui.framework/Headers",
"lib/QtGui.framework/Headers/QtGui",
],
include_prefix = "QtGui",
strip_include_prefix = "lib/QtGui.framework/Headers",
)

cc_library(
name = "qt_mac_widgets",
hdrs = glob(["lib/QtWidgets.framework/Headers/*"]),
include_prefix = "QtWidgets",
includes = [
"lib/QtWidgets.framework/Headers",
"lib/QtWidgets.framework/Headers/QtWidgets",
"lib/QtWidgets.framework/Headers",
"lib/QtWidgets.framework/Headers/QtWidgets",
],
include_prefix = "QtWidgets",
strip_include_prefix = "lib/QtWidgets.framework/Headers",
)

cc_library(
name = "qt_mac",
deps = [
":qt_mac_core",
":qt_mac_gui",
":qt_mac_widgets",
":qt_mac_core",
":qt_mac_gui",
":qt_mac_widgets",
],
)

Expand Down
2 changes: 1 addition & 1 deletion src/bazel/BUILD.qt_win.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ cc_library(
],
}),
hdrs = glob([
"include"
"include",
]),
includes = [
"include",
Expand Down

0 comments on commit 20b02d2

Please sign in to comment.