Apply buildifier to existing files
#1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we start applying lint checks for BUILD.bazel and *.bzl files in GitHub Actions (google#1089), this commit aims to fix existing lint errors by actually applying 'buildifier' [1] locally. This is just a style fix in build files. There must be no observable behavior change in artifacts. [1]: https://github.com/bazelbuild/buildtools/
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we start applying lint checks for
BUILD.bazeland*.bzlfiles in GitHub Actions, this commit aims to fix existing lint errors by actually applyingbuildifierlocally.This is just a style fix in build files. There must be no observable behavior change in artifacts.
Issue IDs
buildifiercommand in GitHub Actions #1089Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
git clone https://github.com/google/mozc.gitgo install github.com/bazelbuild/buildtools/buildifier@latestbuildifier --mode=diff -r .