Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable switching to DIRECT mode using the mouse. #1061

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Enable switching to DIRECT mode using the mouse. #1061

merged 1 commit into from
Sep 17, 2024

Commits on Sep 15, 2024

  1. Enable switching to DIRECT mode using the mouse. 

    This is about addressing the problem where selecting DIRECT with the mouse to switch input modes doesn't work.

In the PropertyHandler::ProcessPropertyActivate function, the processing for DIRECT mode is being skipped. This is because DIRECT=0 as defined in src/protocol/commands.proto#L51, so !entry->composition_mode is evaluated as true.
As a result, while the DIRECT menu item exists, it is not linked to the actual processing that should be executed for DIRECT.
    @phoepsilonix
    phoepsilonix committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    4cba369 View commit details
    Browse the repository at this point in the history