Enable switching to DIRECT mode using the mouse. #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is about addressing the problem where selecting DIRECT with the mouse to switch input modes doesn't work. In the PropertyHandler::ProcessPropertyActivate function, the processing for DIRECT mode is being skipped. This is because DIRECT=0 as defined in src/protocol/commands.proto#L51, so !entry->composition_mode is evaluated as true. As a result, while the DIRECT menu item exists, it is not linked to the actual processing that should be executed for DIRECT.
phoepsilonix
force-pushed
the
patch-2
branch
from
08f85df
to
4cba369
Compare
|
We have merged your PR. |
hiroyuki-komatsu
added a commit
that referenced
this pull request
Oct 10, 2024
2.30.5595 → 2.30.5618 Conversion * Updated zip code entries (#1063). * Updated word entries (#1068, #1069) Bug fix * Linux: Enabled switching to the DIRECT mode from the menu (#1061) * Linux: Enabled switching modes with Super+Space in Wayland (#853, #1059) * macOS: Fixed the limitation of mouse clicking on the renderer on macOS 15 (120bd93) * Windows: Fixed the setting of Omaha updater for the GoogleJapaneseInput build (#1072) Build * Android: Switched the Bazel rules from WORKSPACE to Bzlmod (#1002) * Android: Updated the Docker build environment * Linux: Update the build environment: Ubuntu 22.04 → 24.04 (#924) * macOS / Windows: Updated the Qt version: 6.7.2 → 6.7.3 (#1065) * Windows: Supported Bazel build (#948) * Windows: Updated the Wix version: 4.0.5 → 5.0.2 (#1070) Code * Performed code refactoring PiperOrigin-RevId: 684295272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is about addressing the problem where selecting DIRECT with the mouse to switch input modes doesn't work.
In the PropertyHandler::ProcessPropertyActivate function, the processing for DIRECT mode is being skipped. This is because DIRECT=0 as defined in src/protocol/commands.proto#L51, so !entry->composition_mode is evaluated as true.
As a result, while the DIRECT menu item exists, it is not linked to the actual processing that should be executed for DIRECT.
Issue IDs
Steps to test new behaviors (if any)
With the above steps, the input mode does not switch to DIRECT mode.
Additional context
There is no problem when switching using keyboard keys such as the full-width/half-width key. This is a problem that occurs when switching by mouse click.