Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update srcmap to collect information for Go projects #3355

Closed
Dor1s opened this issue Feb 6, 2020 · 2 comments
Closed

Update srcmap to collect information for Go projects #3355

Dor1s opened this issue Feb 6, 2020 · 2 comments
Assignees
@Dor1s

Comments

@Dor1s
Copy link
Contributor

Dor1s commented Feb 6, 2020

based on the language attribute in the yaml files.

This blocks #2714 and was blocked by #3297
@Dor1s Dor1s self-assigned this Feb 6, 2020
@Dor1s Dor1s mentioned this issue Apr 12, 2020
Closed
5 tasks
@Dor1s
Copy link
Contributor Author

Dor1s commented Apr 16, 2020

Main problems with this:

  1. srcmap should also check packages inside goroot
  2. we shouldn't do 1) for non Go projects -- will probably need to pass an env variable like LANGUAGE=GO to

    oss-fuzz/infra/gcb/build_project.py

    Line 138 in 13cb49b

    'srcmap > /workspace/srcmap.json && cat /workspace/srcmap.json'
    (or maybe there is a better way)

//cc @inferno-chromium

Dor1s added a commit that referenced this issue Apr 16, 2020
@Dor1s
[infra] Improve srcmap support for Go projects (#3355, #2714).
d69555c
Dor1s added a commit that referenced this issue Apr 17, 2020
@Dor1s
[infra] Improve srcmap support for Go projects (#3355, #2714). (#3664)
8ed2f7a 
* [infra] Improve srcmap support for Go projects (#3355, #2714).

* address review feedback
@Dor1s
Copy link
Contributor Author

Dor1s commented Apr 17, 2020

Should be fixed by #3664

@Dor1s Dor1s closed this as completed Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dor1s Dor1s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dor1s