[infra] Improve srcmap support for Go projects (#3355, #2714). #3664
Conversation
Travis tests have failedHey @Dor1s, TravisBuddy Request Identifier: 6e5a6a70-8036-11ea-ac79-d7a1e92f42eb |
infra/gcb/build_and_run_coverage.py
Outdated
| }, | ||
| ] | ||
| build_steps = build_lib.project_image_steps(name, image, | ||
| project_yaml['language']) |
There was a problem hiding this comment.
nit: move project_yaml['language'] to local var language like others. same for other use below.
| ] | ||
| build_steps = build_lib.project_image_steps(name, image, | ||
| project_yaml['language']) | ||
| build_steps.append({ |
There was a problem hiding this comment.
Can you add a comment on why msan-builder is only used here ?
There was a problem hiding this comment.
done, it's not used in the coverage job because we don't use MSan there
| PATHS_TO_SCAN="$SRC" | ||
|
|
||
| if [[ $FUZZING_LANGUAGE == "go" ]]; then | ||
| PATHS_TO_SCAN="$PATHS_TO_SCAN $GOPATH" |
There was a problem hiding this comment.
What's in $GOPATH if this isn't a Go project? Can we use that to determining whether or not to scan it, rather than introducing another env var?
There was a problem hiding this comment.
It's always set to /root/go in the base-builder and always has a few packages we install, so scanning unconditionally will result in irrelevant Go packages revisions in srcmap of any project we build
infra/gcb/build_and_run_coverage.py
Outdated
| }, | ||
| ] | ||
| build_steps = build_lib.project_image_steps(name, image, | ||
| project_yaml['language']) |
| ] | ||
| build_steps = build_lib.project_image_steps(name, image, | ||
| project_yaml['language']) | ||
| build_steps.append({ |
There was a problem hiding this comment.
done, it's not used in the coverage job because we don't use MSan there
Travis tests have failedHey @Dor1s, TravisBuddy Request Identifier: e53a8fd0-8054-11ea-a03b-f348d6d5339b |
|
Tested on GCB (without updated |
Haven't properly tested this yet, please consider it as a draft, but should be fine to review.
I also wanted to pass
FUZZING_LANGUAGEto thehelper.py shell, but we can't parse yaml without installingpyyamlmodule, so not sure about that, probably not necessary, as users don't typically runsrcmapcommand.