Enhance/6079 - Google Tag container lookup and destinations list JS selectors #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor reducerCallback to update state correctly.
…6079-lookup-destinations-selectors.
Pass correct data params to the endpoint.
…6079-lookup-destinations-selectors.
|
Size Change: +422 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
techanvil
requested changes
Jan 4, 2023
There was a problem hiding this comment.
This is looking good @hussain-t, I have left a couple of suggestions, please take a look.
| } | ||
| ); | ||
| }, | ||
| reducerCallback( |
There was a problem hiding this comment.
This looks like a good opportunity to use createReducer to create an Immer-enabled reducer callback, in order to simplify the reducer here.
It would look something like this. Still not super elegant, but easier to make sense of:
reducerCallback: createReducer(
( state, containerDestinations, { gtmAccountID, gtmContainerID } ) => {
state.containerDestinations[ gtmAccountID ] =
state.containerDestinations[ gtmAccountID ] || {};
state.containerDestinations[ gtmAccountID ][ gtmContainerID ] =
state.containerDestinations[ gtmAccountID ][ gtmContainerID ] ||
[];
state.containerDestinations[ gtmAccountID ][ gtmContainerID ].push(
...containerDestinations
);
}
),There was a problem hiding this comment.
Thanks for the great suggestion, @techanvil. I didn't think of it.
It would look something like this. Still not super elegant, but easier to make sense of:
The above code look good 👍
| } | ||
| ); | ||
| }, | ||
| reducerCallback( state, container, { measurementID } ) { |
There was a problem hiding this comment.
We might as well use createReducer here too, it would simplify the reducer logic to a one-liner:
reducerCallback: createReducer( ( state, container, { measurementID } ) => {
state.containers[ measurementID ] = container;
} ),| @@ -0,0 +1,16 @@ | |||
| { | |||
| "6065482709": { | |||
There was a problem hiding this comment.
Is this real user data here? If so, I'd suggest sanitizing it...
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "G-2C8N8YQ1L7": { | |||
There was a problem hiding this comment.
Same comment applies re. user data sanitization...
techanvil
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist