Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/6079 - Google Tag container lookup and destinations list JS selectors #6367

Merged
merged 21 commits into from
Jan 4, 2023
Merged

Enhance/6079 - Google Tag container lookup and destinations list JS selectors #6367

merged 21 commits into from
Jan 4, 2023

Commits on Dec 19, 2022

  1. Add getGoogleTagContainer fetch store - WIP.

    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    c8dd11a View commit details
    Browse the repository at this point in the history

  2. Add getGoogleTagContainer resolver.

    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    b451ac6 View commit details
    Browse the repository at this point in the history

  3. Combine containers to combineStores.

    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    13dc715 View commit details
    Browse the repository at this point in the history

  4. Add getGoogleTagContainer selector. 

    Refactor reducerCallback to update state correctly.
    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    db6dc05 View commit details
    Browse the repository at this point in the history

  5. Add a fetch store for getGoogleTagContainerDestinations.

    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    aa52546 View commit details
    Browse the repository at this point in the history

  6. Add getGoogleTagContainerDestinations resolver.

    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    9b74ece View commit details
    Browse the repository at this point in the history

  7. Add getGoogleTagContainerDestinations selector.

    @hussain-t
    hussain-t committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    5caad11 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge branch 'develop' of github.com:google/site-kit-wp into enhance/… 

    …6079-lookup-destinations-selectors.
    @hussain-t
    hussain-t committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    ab2b8b6 View commit details
    Browse the repository at this point in the history

  2. Construct the state object. 

    Pass correct data params to the endpoint.
    @hussain-t
    hussain-t committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    c360ae4 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Add tests for getGoogleTagContainer selector.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    bd8190e View commit details
    Browse the repository at this point in the history

  2. Add container mock data.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5ea2f6f View commit details
    Browse the repository at this point in the history

  3. Add container destinations mock data.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    44edd43 View commit details
    Browse the repository at this point in the history

  4. Change Copyright year.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    caac558 View commit details
    Browse the repository at this point in the history

  5. Add tests for getGoogleTagContainerDestinations selector.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0161ca0 View commit details
    Browse the repository at this point in the history

  6. Improve tests.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    d859417 View commit details
    Browse the repository at this point in the history

  7. Improve JS docs.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1cac090 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' of github.com:google/site-kit-wp into enhance/… 

    …6079-lookup-destinations-selectors.
    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    d1c0944 View commit details
    Browse the repository at this point in the history

  9. Add newline at the end of line.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    c4dd8ea View commit details
    Browse the repository at this point in the history

  10. Use createReducer from immer.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    f861f80 View commit details
    Browse the repository at this point in the history

  11. Sanitize mock data.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    54137eb View commit details
    Browse the repository at this point in the history

  12. Sanitize domain name mock data.

    @hussain-t
    hussain-t committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1419d0a View commit details
    Browse the repository at this point in the history