Use engagementRate and display it as a percentage. #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
aaemnnosttv
requested changes
Mar 6, 2023
| @@ -43,6 +43,7 @@ const ANALYTICS_4_METRIC_TYPES = { | |||
| conversions: 'TYPE_INTEGER', | |||
| screenPageViews: 'TYPE_INTEGER', | |||
| engagedSessions: 'TYPE_INTEGER', | |||
| engagementRate: 'TYPE_INTEGER', | |||
There was a problem hiding this comment.
Thanks, I've fixed this on the #6689 branch and cherry-picked the commit here as well.
| @@ -188,7 +188,7 @@ function ModulePopularPagesWidgetGA4( props ) { | |||
| hideOnMobile: true, | |||
| field: 'metricValues.2.value', | |||
| Component: ( { fieldValue } ) => ( | |||
| <span>{ numFmt( fieldValue, { style: 'decimal' } ) }</span> | |||
| <span>{ numFmt( Number( fieldValue ) / 100, '%' ) }</span> | |||
There was a problem hiding this comment.
Should we maybe use parseFloat instead?
Also, fieldValue for engagementRate will be a number between 0 and 1 (inclusive) so we shouldn't need to divide by 100.
There was a problem hiding this comment.
It doesn't look like we need parseFloat() here, just passing fieldValue in to numFmt() without dividing it, while specifying the % format seems fine.
techanvil
force-pushed
the
enhancement/6219-popular-pages-widget-ga4-engagementRate
branch
from
6a3ba27
to
b264e84
Compare
aaemnnosttv
deleted the
enhancement/6219-popular-pages-widget-ga4-engagementRate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed on Slack we need to change from using the
engagedSessionsto theengagementRatemetric, and display it as a percentage.Addresses issue:
ModulePopularPagesWidget#6219Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist