Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VRT "Failed to launch" failure and other key unstable VRTs #9412

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Sep 25, 2024

Summary

Addresses issue:

Relevant technical choices

I spent some time looking into possible solutions to this. I used the troubleshooting guide for Alpine Linux to update the way Chromium is installed in our Docker container.

I created a batch test GitHub action that runs the backstop tests 25X and on my first run, over ~20 tests, it didn't trigger the browser error once! However switching to a new version of Chromium did render a few tests differently so I had to accept those changes. This new version also raised some new unstable tests:

  • AudienceSegmentation_Dashboard_AudienceSelectionPanel_Audience_creation_notice for unknown reasons.
  • WPDashboardApp_WPDashboardWidgets_ReadyWithActivateAnalyticsCTA for unknown reasons.
  • AdSense_Module_Overview_Widget which was another case of the DataBlockGroup component causing issues.

While here I found ways to fix these failing tests and re-ran a batch test.

My new batch test appears to pass reliably without any "Failed to launch browser" errors! It's not 100% unfortunately with some inconsistent tests failing occasionally (3/20 in my last batch test) but it is an improvement from our previous situation.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Sep 25, 2024

Build files for 051d38c are ready:

Copy link

github-actions bot commented Sep 25, 2024

Size Change: 0 B

Total Size: 1.86 MB

ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 58.4 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/32-********************.js 2.76 kB
./dist/assets/js/33-********************.js 2.25 kB
./dist/assets/js/34-********************.js 3.64 kB
./dist/assets/js/35-********************.js 935 B
./dist/assets/js/36-********************.js 893 B
./dist/assets/js/37-********************.js 1.61 kB
./dist/assets/js/38-********************.js 1.57 kB
./dist/assets/js/39-********************.js 1.61 kB
./dist/assets/js/40-********************.js 1.59 kB
./dist/assets/js/41-********************.js 3.11 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.5 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.04 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.95 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.5 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.5 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.8 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 156 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 32.9 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 124 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 175 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 22 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59.6 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 1.01 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.1 kB
./dist/assets/js/googlesitekit-notifications-********************.js 22.5 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/googlesitekit-settings-********************.js 125 kB
./dist/assets/js/googlesitekit-splash-********************.js 86.8 kB
./dist/assets/js/googlesitekit-user-input-********************.js 60.9 kB
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB
./dist/assets/js/googlesitekit-widgets-********************.js 89.7 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.2 kB
./dist/assets/js/runtime-********************.js 1.38 kB

compressed-size-action

@benbowler benbowler changed the title Debug VRT "Failed to launch" failure Fix VRT "Failed to launch" failure and other key unstable VRTs Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants