-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VRT "Failed to launch" failure and other key unstable VRTs #9412
Open
benbowler
wants to merge
15
commits into
develop
Choose a base branch
from
bug/9406-VRT-experimentation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build files for 051d38c are ready:
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
4 tasks
benbowler
changed the title
Debug VRT "Failed to launch" failure
Fix VRT "Failed to launch" failure and other key unstable VRTs
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
I spent some time looking into possible solutions to this. I used the troubleshooting guide for Alpine Linux to update the way Chromium is installed in our Docker container.
I created a batch test GitHub action that runs the backstop tests 25X and on my first run, over ~20 tests, it didn't trigger the browser error once! However switching to a new version of Chromium did render a few tests differently so I had to accept those changes. This new version also raised some new unstable tests:
AudienceSegmentation_Dashboard_AudienceSelectionPanel_Audience_creation_notice
for unknown reasons.WPDashboardApp_WPDashboardWidgets_ReadyWithActivateAnalyticsCTA
for unknown reasons.AdSense_Module_Overview_Widget
which was another case of theDataBlockGroup
component causing issues.While here I found ways to fix these failing tests and re-ran a batch test.
My new batch test appears to pass reliably without any "Failed to launch browser" errors! It's not 100% unfortunately with some inconsistent tests failing occasionally (3/20 in my last batch test) but it is an improvement from our previous situation.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist