Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VRT "Failed to launch" failure and other key unstable VRTs #9412

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ ReadyWithActivateAnalyticsCTA.args = {

ReadyWithActivateAnalyticsCTA.scenario = {
label: 'Views/WPDashboardApp/WPDashboardWidgets/ReadyWithActivateAnalyticsCTA',
delay: 3000,
delay: 6000, // This extra delay is required to fix unstable VRTs.
};

export const ReadyWithCompleteAnalyticsActivationCTA = Template.bind( {} );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ AudienceCreationNoticeOneAdded.args = {
};
AudienceCreationNoticeOneAdded.scenario = {
label: 'Modules/Analytics4/Components/AudienceSegmentation/Dashboard/AudienceSelectionPanel/AudienceCreationNoticeOneAdded',
delay: 1500, // Delay here is required to prevent inconsistent rendering of the Create button text.
};

export const AudienceCreationNoticeWithOAuthError = Template.bind( {} );
Expand Down
15 changes: 14 additions & 1 deletion docker/backstopjs/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,21 @@ ARG BACKSTOPJS_VERSION=6.1.1

ENV BACKSTOPJS_VERSION=$BACKSTOPJS_VERSION

RUN apk add --no-cache \
chromium \
nss \
freetype \
harfbuzz \
ca-certificates \
ttf-freefont \
nodejs \
npm \
openrc \
dbus

ENV PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium-browser

RUN apk upgrade --no-cache --available && \
apk add --no-cache openrc dbus chromium nodejs npm && \
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true npm i -g backstopjs@${BACKSTOPJS_VERSION} && \
npm cache clean -f && \
rm -rf /root/.cache && \
Expand Down
29 changes: 15 additions & 14 deletions stories/module-adsense-components.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ const generateAdSenseData = makeReportDataGenerator( getAdSenseMockResponse );

// @TODO: Update it to GA4.
const topEarningPagesArgs = {
startDate: '2020-08-15',
endDate: '2020-09-11',
startDate: '2021-08-15',
endDate: '2021-09-11',
dimensions: [ 'pageTitle', 'pagePath' ],
metrics: [ { name: 'totalAdRevenue' } ],
orderBys: [ { metric: { metricName: 'totalAdRevenue' } } ],
Expand All @@ -54,16 +54,16 @@ const topEarningPagesArgs = {
// These components make a simple AdSense report query to determine the
// currency that should be displayed in the report table.
const getCurrencyFromReportOptions = {
startDate: '2020-08-15',
endDate: '2020-09-11',
startDate: '2021-08-15',
endDate: '2021-09-11',
metrics: 'ESTIMATED_EARNINGS',
};

generateReportBasedWidgetStories( {
moduleSlugs: [ 'adsense', 'analytics-4' ],
datastore: MODULES_ANALYTICS_4,
group: 'AdSense Module/Components/Dashboard/Top Earning Pages Widget',
referenceDate: '2020-09-12',
referenceDate: '2021-09-12',
...generateAnalyticsData( topEarningPagesArgs ),
options: topEarningPagesArgs,
setup: ( registry, variantName ) => {
Expand Down Expand Up @@ -97,10 +97,11 @@ generateReportBasedWidgetStories( {
} );

generateReportBasedWidgetStories( {
delay: 3000, // Allow time for the text resizing code to finish to prevent inconsistent rendering of chart during VRTs.
moduleSlugs: [ 'adsense' ],
datastore: MODULES_ADSENSE,
group: 'AdSense Module/Components/Module/Overview Widget',
referenceDate: '2020-11-25',
referenceDate: '2021-11-25',
zeroing,
...generateAdSenseData( [
{
Expand All @@ -110,8 +111,8 @@ generateReportBasedWidgetStories( {
'IMPRESSIONS',
'PAGE_VIEWS_CTR',
],
startDate: '2020-10-28',
endDate: '2020-11-24',
startDate: '2021-10-28',
endDate: '2021-11-24',
},
{
dimensions: [ 'DATE' ],
Expand All @@ -121,8 +122,8 @@ generateReportBasedWidgetStories( {
'IMPRESSIONS',
'PAGE_VIEWS_CTR',
],
startDate: '2020-10-28',
endDate: '2020-11-24',
startDate: '2021-10-28',
endDate: '2021-11-24',
},
{
metrics: [
Expand All @@ -131,8 +132,8 @@ generateReportBasedWidgetStories( {
'IMPRESSIONS',
'PAGE_VIEWS_CTR',
],
startDate: '2020-09-30',
endDate: '2020-10-27',
startDate: '2021-09-30',
endDate: '2021-10-27',
},
{
dimensions: [ 'DATE' ],
Expand All @@ -142,8 +143,8 @@ generateReportBasedWidgetStories( {
'IMPRESSIONS',
'PAGE_VIEWS_CTR',
],
startDate: '2020-09-30',
endDate: '2020-10-27',
startDate: '2021-09-30',
endDate: '2021-10-27',
},
] ),
additionalVariants: {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading