Bump a bunch of deps at once. #1150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpovirk
force-pushed
the
bump
branch
2 times, most recently
from
2ff7905
to
d24c093
Compare
Notes: - The GWT bump requires changing the browser setting from "FF38" to "FF." - I skipped the `jsinterop-annotations` bump to 2.1.0 because it's built with `-target 11`, while we still support 8. (Closes #1147) (I've noted this in google/guava#6614) - The command I used is: ``` mvn org.codehaus.mojo:versions-maven-plugin:2.16.0:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -Dexcludes=com.google.guava:guava ``` That tried to update protobuf to a release candidate. I had thought that perhaps this was the result of [a protobuf change from "-rc1" to "-rc-1"](protocolbuffers/protobuf#6522), but I'm wondering if it's actually just that `versions-maven-plugin` (in contrast to Dependabot) counts release candidates [as releases](https://www.mojohaus.org/versions/versions-maven-plugin/use-latest-releases-mojo.html)? I'd have to investigate further and perhaps [use `rulesUri`](https://stackoverflow.com/a/46935363/28465). But since we normally rely on Dependabot (and I was using `versions-maven-plugin` here only "to make things easier"... :)), I'm not going to worry about it now. ... Also, it looks like protobuf 4 might remove the `hasPresence()` method that we'd migrated to back in cl/508716698. If so, there's a good chance that the protobuf team will fix things for us :) If not, I'm assuming that this will relate to ["Editions."](https://protobuf.dev/editions/overview/) Fixes #1149 Fixes #1148 Fixes #1146 Fixes #1145
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Notes: - The GWT bump requires changing the browser setting from "FF38" to "FF." - I skipped the `jsinterop-annotations` bump to 2.1.0 because it's built with `-target 11`, while we still support 8. (Closes #1147) (I've noted this in google/guava#6614) - The command I used is: ``` mvn org.codehaus.mojo:versions-maven-plugin:2.16.0:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -Dexcludes=com.google.guava:guava ``` That tried to update protobuf to a release candidate. I had thought that perhaps this was the result of [a protobuf change from "-rc1" to "-rc-1"](protocolbuffers/protobuf#6522), but I'm wondering if it's actually just that `versions-maven-plugin` (in contrast to Dependabot) counts release candidates [as releases](https://www.mojohaus.org/versions/versions-maven-plugin/use-latest-releases-mojo.html)? I'd have to investigate further and perhaps [use `rulesUri`](https://stackoverflow.com/a/46935363/28465). But since we normally rely on Dependabot (and I was using `versions-maven-plugin` here only "to make things easier"... :)), I'm not going to worry about it now. ... Also, it looks like protobuf 4 might remove the `hasPresence()` method that we'd migrated to back in cl/508716698. If so, there's a good chance that the protobuf team will fix things for us :) If not, I'm assuming that this will relate to ["Editions."](https://protobuf.dev/editions/overview/) Fixes #1149 Fixes #1148 Fixes #1146 Fixes #1145 Fixes #1150 RELNOTES=n/a PiperOrigin-RevId: 550553262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
jsinterop-annotationsbump to 2.1.0 because it's builtwith
-target 11, while we still support 8.(Closes Bump com.google.jsinterop:jsinterop-annotations from 2.0.0 to 2.1.0 #1147)
(I've noted this in Figure out when to drop Java 8 support guava#6614)
that perhaps this was the result of a protobuf change from "-rc1" to
"-rc-1", but
I'm wondering if it's actually just that
versions-maven-plugin(incontrast to Dependabot) counts release candidates as
releases?
I'd have to investigate further and perhaps use
rulesUri. But since wenormally rely on Dependabot (and I was using
versions-maven-pluginhere only "to make things easier"... :)), I'm not going to worry about
it now.
...
Also, it looks like protobuf 4 might remove the
hasPresence()methodthat we'd migrated to back in cl/508716698. If so, there's a good
chance that the protobuf team will fix things for us :) If not, I'm
assuming that this will relate to
"Editions."
Fixes #1149
Fixes #1148
Fixes #1146
Fixes #1145