Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump a bunch of deps at once. #1150

Closed
wants to merge 1 commit into from
Closed

Bump a bunch of deps at once. #1150

wants to merge 1 commit into from

Commits on Jul 24, 2023

  1. Bump a bunch of deps at once.

    Notes:
    
    - The GWT bump requires changing the browser setting from "FF38" to "FF."
    - I skipped the `jsinterop-annotations` bump to 2.1.0 because it's built
      with `-target 11`, while we still support 8.
      (Closes #1147)
      (I've noted this in google/guava#6614)
    - The command I used is:
      ```
      mvn org.codehaus.mojo:versions-maven-plugin:2.16.0:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -Dexcludes=com.google.guava:guava
      ```
      That tried to update protobuf to a release candidate. I had thought
      that perhaps this was the result of [a protobuf change from "-rc1" to
      "-rc-1"](protocolbuffers/protobuf#6522), but
      I'm wondering if it's actually just that `versions-maven-plugin` (in
      contrast to Dependabot) counts release candidates [as
      releases](https://www.mojohaus.org/versions/versions-maven-plugin/use-latest-releases-mojo.html)?
      I'd have to investigate further and perhaps [use
      `rulesUri`](https://stackoverflow.com/a/46935363/28465). But since we
      normally rely on Dependabot (and I was using `versions-maven-plugin`
      here only "to make things easier"... :)), I'm not going to worry about
      it now.
      ...
      Also, it looks like protobuf 4 might remove the `hasPresence()` method
      that we'd migrated to back in cl/508716698. If so, there's a good
      chance that the protobuf team will fix things for us :) If not, I'm
      assuming that this will relate to
      ["Editions."](https://protobuf.dev/editions/overview/)
    
    Fixes #1149
    Fixes #1148
    Fixes #1146
    Fixes #1145
    cpovirk committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    120cb1b View commit details
    Browse the repository at this point in the history