Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepted risk: Immutable types assumed not to contain UnsafeCells #1358

Open
Tracked by #671
joshlf opened this issue May 30, 2024 · 0 comments
Open
Tracked by #671

Accepted risk: Immutable types assumed not to contain UnsafeCells #1358

joshlf opened this issue May 30, 2024 · 0 comments

Comments

@joshlf
Copy link
Member

joshlf commented May 30, 2024

As part of #1155, we need guarantees that certain standard library types such as Box and NonZeroXxx and even built-ins such as usize do not contain UnsafeCells. Per rust-lang/unsafe-code-guidelines#492, it is difficult to get this guarantee, but it's also incredibly obvious that it's true and would be absurd to change (and certainly absurd in a way that doesn't just result in these types containing UnsafeCells, but in a way that permits interior mutation to be exercised, which is really what Immutable cares about).

This issue tracks that this is an accepted risk, and we're going to proceed with 0.8 anyway.

@joshlf joshlf mentioned this issue May 30, 2024
87 tasks
@joshlf joshlf added the blocking-next-release This issue should be resolved before we release on crates.io label May 30, 2024
joshlf added a commit that referenced this issue Sep 7, 2024
Adds some informal proofs as accepted risks per #1358

Makes progress on #896
@joshlf joshlf changed the title Accepted risk: Box et al containing UnsafeCells Accepted risk: Immutable types assumed not to contain UnsafeCells Sep 7, 2024
joshlf added a commit that referenced this issue Sep 7, 2024
Adds some informal proofs as accepted risks per #1358

Makes progress on #896
github-merge-queue bot pushed a commit that referenced this issue Sep 7, 2024
Adds some informal proofs as accepted risks per #1358

Makes progress on #896
@joshlf joshlf removed the blocking-next-release This issue should be resolved before we release on crates.io label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant