Write some safety proofs #1615
Merged
Write some safety proofs #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
approved these changes
Sep 7, 2024
src/impls.rs
Outdated
| @@ -435,7 +433,9 @@ safety_comment! { | |||
|
|
|||
| safety_comment! { | |||
| /// SAFETY: | |||
| /// TODO(#896): Write this safety proof before the next stable release. | |||
| /// Function objects (`fn()` and `extern "C" fn()`) self-evidently do not | |||
There was a problem hiding this comment.
Suggested change
| /// Function objects (`fn()` and `extern "C" fn()`) self-evidently do not | |
| /// Function pointers (`fn()` and `extern "C" fn()`) self-evidently do not |
Function objects describes the broader set that includes closures, which may contain UnsafeCells.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
+ Coverage 87.77% 87.83% +0.06%
==========================================
Files 15 15
Lines 5594 5623 +29
==========================================
+ Hits 4910 4939 +29
Misses 684 684 ☔ View full report in Codecov by Sentry. |
joshlf
force-pushed
the
accepted-risk-unsafe-cells
branch
from
25a81a1
to
912bc3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some informal proofs as accepted risks per #1358
Makes progress on #896