Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_as_bytes_methods fails on powerpc #23

Closed
joshlf opened this issue Oct 4, 2022 · 0 comments · Fixed by #34
Closed

test_as_bytes_methods fails on powerpc #23

joshlf opened this issue Oct 4, 2022 · 0 comments · Fixed by #34

Comments

@joshlf
Copy link
Member

joshlf commented Oct 4, 2022 •
edited
Loading

From this test job:

thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `[0, 0, 0, 1, 0, 0, 0, 2, 0, 0, 0, 0]`,
 right: `[1, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0]`', src/lib.rs:2885:9

Fix the bug and re-enable the test in .github/workflows/ci.yml.
frazar added a commit to frazar/zerocopy that referenced this issue Oct 8, 2022
@frazar
Fix as_bytes() test for big endian targets
8ed0321 
The tests for the as_bytes() method assumed that bytes are stored in
little endian order, which is not the case for PowerPC.
Fix the alignment tests so that they work on both little and big endian
targets.

Fixes google#23
@frazar frazar mentioned this issue Oct 8, 2022
Merged
frazar added a commit to frazar/zerocopy that referenced this issue Oct 9, 2022
@frazar
Fix as_bytes() test for big endian targets
059cfac 
The tests for the as_bytes() method assumed that bytes are stored in
little endian order, which is not the case for PowerPC.
Fix the alignment tests so that they work on both little and big endian
targets.

Fixes google#23
@joshlf joshlf closed this as completed in #34 Oct 9, 2022
joshlf pushed a commit that referenced this issue Oct 9, 2022
@frazar
Fix as_bytes() test for big endian targets (#34)
49fc9ff 
The tests for the `as_bytes` method assumed that bytes are stored in
little endian order, which is not the case for PowerPC. Fix the alignment
tests so that they work on both little and big endian targets.

Fixes #23

Co-authored-by: Francesco Zardi <[email protected]>
@joshlf joshlf mentioned this issue Jul 26, 2023
Closed
joshlf pushed a commit that referenced this issue Aug 3, 2023
@frazar @joshlf
Fix as_bytes() test for big endian targets (#34)
1e2c835 
The tests for the `as_bytes` method assumed that bytes are stored in
little endian order, which is not the case for PowerPC. Fix the alignment
tests so that they work on both little and big endian targets.

Fixes #23

Co-authored-by: Francesco Zardi <[email protected]>
@joshlf joshlf mentioned this issue Aug 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix as_bytes() test for big endian targets frazar/zerocopy
1 participant
@joshlf